Skip to content

Commit 0cc0b5b

Browse files
anand-kyanand-ky
authored
Merge branch 'develop' into feature/RDKEMW-11249_ctrlm-v1.1.7_vsdk-v1.0.8
2 parents be2664d + 5932871 commit 0cc0b5b

File tree

6 files changed

+248
-43
lines changed

6 files changed

+248
-43
lines changed

‎.github/ISSUE_TEMPLATE/middleware_change_request.yml‎

Lines changed: 81 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,81 @@
1+
name: RDK-E Middleware Change Request
2+
description: Change Request for RDK-E Middleware
3+
title: "<JIRA TICKET>:<Ticket Title> "
4+
labels: ["MW Change Request"]
5+
body:
6+
- type: markdown
7+
attributes:
8+
value: |
9+
Change Request for RDK-E Middleware
10+
11+
- type: textarea
12+
id: description
13+
attributes:
14+
label: Description
15+
description: Provide a clear and concise description of the feature or bug ticket
16+
placeholder: Describe the changes you are bringing
17+
validations:
18+
required: true
19+
20+
- type: textarea
21+
id: additional-context
22+
attributes:
23+
label: Additional Context
24+
description: Add any other context, screenshots, or examples about the feature request
25+
placeholder: Any other relevant information
26+
validations:
27+
required: false
28+
29+
- type: textarea
30+
id: dod-checklist
31+
attributes:
32+
label: Definition of Done (DoD)
33+
description: Mark items with [x] and replace the placeholder text on Details lines with actual information.
34+
value: |
35+
Please complete the following Middleware Layer Integration checklist items to ensure all requirements for changes to be merged.
36+
37+
**IMPORTANT:** Do NOT provide any proprietary information including:
38+
- Links to internal Automatics/CI builds
39+
- Links to internal Confluence pages
40+
- Any other Comcast/Sky proprietary or confidential information
41+
- Development Build/Setup Details
42+
43+
Only provide publicly accessible information and links. All proprietary information should be added to JIRA Ticket.
44+
45+
---
46+
47+
- [ ] **Middleware component tags with changelog**
48+
- Details: For instance https://github.com/rdkcentral/hdmicec/blob/1.0.7/CHANGELOG.md. Include all components that need to go together for Builds to work.
49+
50+
- [ ] **Tested on STBs**
51+
52+
- [ ] **Tested on TVs**
53+
54+
- [ ] **Dependent Layer tags (App Layer, OSS, Product, Halif Headers, Vendor Layers)**
55+
- Details: (e.g. https://github.com/rdk-e/meta-image-support/blob/4.1.1/CHANGELOG.md)
56+
57+
- [ ] **Do Widgets Need Publishing**
58+
- Details: (Provide context if widgets are involved)
59+
60+
- [ ] **Copilot review for Components**
61+
- Details: (Any comments on the review)
62+
63+
- [ ] **Component Test**
64+
- Details: Share Testing done as part of components release
65+
66+
- [ ] **Integration Testing**
67+
- Details: Provide details on Integration testing done within Middleware layer
68+
69+
- [ ] **E2E Testing**
70+
- Details: Provide details on end to end testing done across all layers
71+
72+
- [ ] **Performance Testing**
73+
- Details: Provide details on performance testing done
74+
75+
- [ ] **Static code analysis/Coverity**
76+
- Details: Share Coverity runs for components affected
77+
78+
- [ ] **Manual Functional Test**
79+
80+
validations:
81+
required: true

.github/workflows/validate_pr_desc.yml renamed to .github/workflows/validate_pr_title.yml

Lines changed: 9 additions & 33 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
1-
name: PR Description Validation
1+
name: PR Title Validation
22

33
on:
44
pull_request:
55
branches: [develop]
66
types: [opened, edited, synchronize]
77

88
jobs:
9-
validate-pr-description:
9+
validate-pr-title:
1010
runs-on: ubuntu-latest
1111
steps:
1212
- name: Checkout code
1313
uses: actions/checkout@v4
1414

15-
- name: Validate PR Description
15+
- name: Validate PR Title
1616
env:
1717
PR_TITLE: ${{ github.event.pull_request.title }}
1818
PR_BODY: ${{ github.event.pull_request.body }}
@@ -74,40 +74,16 @@ jobs:
7474
return 0
7575
}
7676
77-
# Track validation results
78-
TITLE_VALID=true
79-
DESCRIPTION_VALID=true
80-
81-
# Validate PR Title
77+
# Validate PR Title (always required)
8278
echo "=== Validating PR Title ==="
8379
if ! validate_ticket "$PR_TITLE" "PR title"; then
84-
TITLE_VALID=false
85-
fi
86-
87-
echo ""
88-
echo "=== Validating PR Description ==="
89-
# Validate PR Description
90-
if [ -n "$PR_BODY" ]; then
91-
if ! validate_ticket "$PR_BODY" "PR description"; then
92-
DESCRIPTION_VALID=false
93-
fi
94-
else
95-
echo "ERROR: PR description is empty."
96-
echo "Both PR title and description must contain valid ticket IDs."
97-
DESCRIPTION_VALID=false
98-
fi
99-
100-
echo ""
101-
echo "=== Validation Summary ==="
102-
echo "PR Title: $([ "$TITLE_VALID" = true ] && echo "PASSED" || echo " FAILED")"
103-
echo "PR Description: $([ "$DESCRIPTION_VALID" = true ] && echo "PASSED" || echo "FAILED")"
104-
105-
# Exit with error if either validation failed
106-
if [ "$TITLE_VALID" = false ] || [ "$DESCRIPTION_VALID" = false ]; then
10780
echo ""
108-
echo "VALIDATION FAILED: Both PR title and description must contain valid ticket IDs from the approved list: ${VALID_TICKET_IDS[@]}"
81+
echo "VALIDATION FAILED: PR title must contain a valid ticket ID from the approved list: ${VALID_TICKET_IDS[@]}"
10982
exit 1
11083
fi
11184
11285
echo ""
113-
echo "ALL VALIDATIONS PASSED! Both PR title and description contain valid ticket IDs."
86+
echo "=== PR Title Validation PASSED ==="
87+
echo "Ticket ID found in PR title."
88+
echo ""
89+
echo "ALL VALIDATIONS PASSED! PR title contains a valid ticket ID."

0 commit comments

Comments
 (0)