is AVClock instance required for invoke sink?

[hari22yuva]

is AVClock instance required for invoke sink?

[hari22yuva]

After discuses conclude that need to update the documentation about the sink.
And create issue to updated the interface documentation

[shafi12]

The setClockMode API of the AVClock allows the middleware (MW) to configure the clock source as Auto, PCR, Video, or Audio, depending on the synchronization strategy required.
On the audio sink hal service , this clock mode is retrieved by checking whether the AVClock object has been created by the middleware and whether the clock mode has been set accordingly. However, in the current flow, the AVClock controller object is not instantiated, which causes the audio sink to fail with an error indicating that the AVClock mode is not set.
This configuration is mandatory at the audio sink before PCM data is pushed along with the corresponding PTS, as it determines the synchronization mechanism to be used. Without a valid AVClock mode, the SoC cannot perform proper audio–video synchronization, leading to incorrect playback timing.

[Ulrond]

That documentation is quite clear, and notably AVClock is not mentioned anywhere in the audiosink docs as a precondition for anything. The sequence diagram shows the complete happy path — open(), start(), queueAudioFrame() — with no AVClock association step in sight.

The gap is that it doesn't explicitly say AVClock is not required, let me fix that

[Ulrond]

Concluded — AVClock is not a precondition for Audio Sink operation. The Audio Sink documentation and sequence diagrams make no reference to AVClock as a required step. Closing.