Bug: wpeframework-sharedstorage.service should start after wpeframework-cloudstore.service

[npoltorapavlo]

Problem/Opportunity

thunder-startup-services/systemd/system/wpeframework-sharedstorage.service

Lines 3 to 4 in 54b9054

	Requires=wpeframework.service wpeframework-persistentstore.service
	After=wpeframework.service wpeframework-persistentstore.service

sharedstorage when activates queries interfaces of persistentstore and cloudstore. As there's no ordering between sharedstorage and cloudstore in services, or other ways, it is a race condition. If sharedstorage activates before cloudstore, it will query null, and return ERROR_NOT_SUPPORTED when used.

Steps to reproduce

No response

Expected Behavior

wpeframework-sharedstorage.service should start after wpeframework-cloudstore.service

Actual Behavior

Race condition

Notes (Optional)

No response

[srikanth-vv]

@npoltorapavlo :
Since CloudStore doesn't have end point for rdkm, this dependency comes as drop-in here

[npoltorapavlo]

@srikanth-vv if other service doesn't exist, such dependency is no-op. I would define it here for clarity

Besides, the drop-in uses sed which may fail or have no effect if original line changes.

https://github.com/rdkcentral/entservices-infra/blob/develop/SharedStorage/SharedStorageImplementation.cpp
open source, queries "org.rdk.CloudStore"