Skip to content

Bug: Consider a better solution instead of "ConditionPathExists=/tmp/wpeframeworkstarted" and path unit wpeframework-services.path #140

@npoltorapavlo

Description

@npoltorapavlo

Problem/Opportunity

Systemd path unit common use case is to automatically execute a service when a specific file changes.
E.g a service relies on a configuration file, and you want to automatically restart or reload the service whenever that configuration file is modified.
Thus "ConditionPathExists=/tmp/wpeframeworkstarted" lines and path unit https://github.com/rdkcentral/thunder-startup-services/blob/develop/systemd/system/wpeframework-services.path
are probably misused - serve a purpose of restart/stop when other unit restart/stop. To restart/stop dependent services, PartOf= could be used (when systemd stops or restarts the units listed here, the action is propagated to this unit).
That would be a more clear way to define dependencies between units. Lines "ConditionPathExists=/tmp/wpeframeworkstarted" and path unit are not self-explanatory.
Please remove "ConditionPathExists=/tmp/wpeframeworkstarted" and path unit wpeframework-services.path and try the following instead: PartOf=.

Steps to reproduce

No response

Expected Behavior

Unit files should be self-explanatory and easy to understand

Actual Behavior

There are lines "ConditionPathExists=/tmp/wpeframeworkstarted" in units and path unit wpeframework-services.path that are probably misused and confusing

Notes (Optional)

No response

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions