Conversation
…nt64) Added UT_KVP_PROFILE_GET_INT8/INT16/INT32/INT64 getter macros and UT_ASSERT_KVP_EQUAL_PROFILE_INT8/INT16/INT32/INT64 assert macros in ut_kvp_profile.h for the new signed integer APIs from ut-control. Also added: - Weak implementations for ut_kvp_getInt8/16/32/64Field - Test data for signed integers in YAML and JSON test assets - Test functions exercising the new macros in both YAML and JSON suites Co-authored-by: kanjoe24 <165808281+kanjoe24@users.noreply.github.com> Agent-Logs-Url: https://github.com/rdkcentral/ut-core/sessions/75aa1437-0247-48e0-963d-421645dd54a0
…ignore Co-authored-by: kanjoe24 <165808281+kanjoe24@users.noreply.github.com> Agent-Logs-Url: https://github.com/rdkcentral/ut-core/sessions/75aa1437-0247-48e0-963d-421645dd54a0
There was a problem hiding this comment.
Pull request overview
This PR extends the KVP “profile” convenience macros and accompanying tests/assets to support signed integer retrieval/assertion (int8/int16/int32/int64).
Changes:
- Added
UT_KVP_PROFILE_GET_INT{8,16,32,64}andUT_ASSERT_KVP_EQUAL_PROFILE_INT{8,16,32,64}macros. - Added new unit tests validating signed integer access for both YAML and JSON profiles.
- Updated test YAML/JSON assets with signed integer fields; added
.variantto.gitignore.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
include/ut_kvp_profile.h |
Adds profile getter + assert macros for signed integer APIs. |
tests/src/c_source/ut_test_kvp_profile.c |
Adds test cases and registers them for YAML/JSON suites. |
tests/src/assets/test_kvp.yaml |
Adds signed integer test values; fixes list indentation/formatting. |
tests/src/assets/test_kvp.json |
Adds signed integer test values. |
tests/src_weak/ut_test_weak_kvp.c |
Adds weak stub implementations for the new signed integer getters. |
.gitignore |
Ignores .variant generated by the build. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…eak stubs Co-authored-by: kanjoe24 <165808281+kanjoe24@users.noreply.github.com> Agent-Logs-Url: https://github.com/rdkcentral/ut-core/sessions/d484a2b7-dbe0-41a6-a7c2-c04929eb352d
kanjoe24
commented
Mar 25, 2026
Co-authored-by: kanjoe24 <165808281+kanjoe24@users.noreply.github.com> Agent-Logs-Url: https://github.com/rdkcentral/ut-core/sessions/aa66385a-4b20-4032-aeba-d5710d394a7f
Contributor
Author
|
test logs: |
Ulrond
approved these changes
Mar 25, 2026
github-project-automation
bot
moved this from Todo
to Approved For Merge
in UT-Core Roadmap
github-project-automation
bot
moved this from Approved For Merge
to Resolved
in UT-Core Roadmap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add KVP_PROFILE macros for signed integer APIs (int8, int16, int32, int64)