Skip to content

Commit 69d73ee

Browse files
Small update for smoother errorhandling, also fix of destroy-method.
1 parent 9d7aae7 commit 69d73ee

File tree

2 files changed

+12
-3
lines changed

2 files changed

+12
-3
lines changed

rdmo_client/client/http.py

Lines changed: 11 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,6 @@
11
import requests
2+
from requests.exceptions import JSONDecodeError as RequestsJSONDecodeError
3+
#from json import JSONDecodeError
24

35

46
class HTTPClient(object):
@@ -9,10 +11,17 @@ def __init__(self, base_url, auth, headers):
911
def parse_response(self, response):
1012
try:
1113
response.raise_for_status()
12-
return response.json()
1314
except requests.exceptions.HTTPError as e:
14-
print(response.json())
15+
try:
16+
print(response.json())
17+
except (RequestsJSONDecodeError):
18+
print(response.content)
1519
raise e
20+
try:
21+
response_return = response.json()
22+
except (RequestsJSONDecodeError):
23+
response_return = response.content
24+
return response_return
1625

1726
def get(self, url, params={}):
1827
response = requests.get(self.base_url + url, params=params, auth=self.auth, headers=self.headers)

rdmo_client/client/rest.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,4 +38,4 @@ def update(self, resource_url, pk, data, **kwargs):
3838

3939
def destroy(self, resource_url, pk, **kwargs):
4040
url = self._build_url(resource_url, kwargs, pk)
41-
return self.delete(url, pk)
41+
return self.delete(url) #pk included in url, thats sufficient

0 commit comments

Comments
 (0)