Add spec acceptance

Author: xbezdick

.travis.sh

@@ -2,3 +2,5 @@
 set -ev
 rake lint
 rake syntax
+# we can't ssh to localhost
+#rspec spec/acceptance

.travis.yml

@@ -7,7 +7,6 @@ matrix:
   fast_finish: true
 env:
   matrix:
-    - PUPPET_GEM_VERSION="~> 3.7.0"
 notifications:
   email: false
   irc:

Gemfile

@@ -15,6 +15,10 @@ group :development, :test do
   gem 'puppet-lint-leading_zero-check'
   gem 'puppet-lint-variable_contains_upcase'
   gem 'puppet-lint-numericvariable'
+
+  gem 'rspec', :require => false
+  gem 'beaker-rspec', :require => false
+  gem 'beaker-puppet_install_helper', :require => false
 end
 
 if puppetversion = ENV['PUPPET_GEM_VERSION']

manifests/lockdown_whitelist.pp

@@ -52,9 +52,9 @@
 ) {
   include ::firewalld::configuration
 
-  if $users != [] {
-    # TODO: assert there's one (and only one of) {username, userid}
-  }
+#  if $users != [] {
+#    # TODO: assert there's one (and only one of) {username, userid}
+#  }
 
   file {
     '/etc/firewalld/lockdown-whitelist.xml':

spec/acceptance/basic_firewalld_spec.rb

@@ -0,0 +1,27 @@
+require 'spec_helper_acceptance'
+
+describe 'firewalld class' do
+  context 'simple firewall' do
+    it 'should work with no errors' do
+      pp= <<-EOS
+      firewalld::zone { 'usata':
+        description => 'Mine',
+        rich_rules => [{
+          family => 'ipv4',
+          source => { address => '192.168.1.1', invert => false},
+          service => 'dns',
+          action => { action_type => 'accept', }
+        }],
+        services    => ['ssh', 'dhcpv6-client', 'dns', 'https', 'kerberos', 'http', 'kpasswd', 'ldap', 'ldaps', 'ntp'],
+      }
+      class { 'firewalld::configuration':
+        default_zone => 'usata',
+      }
+      EOS
+
+      # Run it twice and test for idempotency
+      apply_manifest(pp, :catch_failures => true)
+      apply_manifest(pp, :catch_changes => true)
+    end
+  end
+end

spec/acceptance/nodesets/default.yml

@@ -0,0 +1,10 @@
+HOSTS:
+  test:
+    platform: el-7-x86_64
+    roles:
+      - master
+    hypervisor : none
+    ip: 127.0.0.1
+CONFIG:
+  type: foss
+  set_env: false

spec/spec.opts

@@ -0,0 +1,6 @@
+--format
+s
+--colour
+--loadby
+mtime
+--backtrace

spec/spec_helper.rb

@@ -0,0 +1,2 @@
+require 'puppetlabs_spec_helper/module_spec_helper'
+#require 'shared_examples'

spec/spec_helper_acceptance.rb

@@ -0,0 +1,4 @@
+require 'beaker-rspec'
+require 'beaker/puppet_install_helper'
+
+run_puppet_install_helper