[NEP-18619]: Addressing review comments

Author: soundarya-mv

lib/superset/dashboard/datasets/list.rb

@@ -7,14 +7,14 @@ module Superset
   module Dashboard
     module Datasets
       class List < Superset::Request
-        attr_reader :id, :include_filter_datasets # dashboard id
+        attr_reader :id, :include_filter_datasets # id - dashboard id
 
         def self.call(id)
           self.new(id).list
         end
 
-        def initialize(id, include_filter_datasets = false)
-          @id = id
+        def initialize(dashboard_id:, include_filter_datasets: false)
+          @id = dashboard_id
           @include_filter_datasets = include_filter_datasets
         end
 
@@ -50,7 +50,7 @@ def datasets_details
         private
 
         def filter_dataset_ids
-          @filter_dataset_ids ||= Dashboard::Filters::List.new(id).perform
+          @filter_dataset_ids ||= dashboard.filter_configuration.map { |c| c['targets'] }.flatten.compact.map { |c| c['datasetId'] }.flatten.compact
         end
 
         def filter_datasets(filter_dataset_ids_not_used_in_charts)
@@ -88,7 +88,11 @@ def rows
 
         # when displaying a list of datasets, show dashboard title as well
         def title
-          @title ||= [id, Superset::Dashboard::Get.new(id).title].join(' ')
+          @title ||= [id, dashboard.title].join(' ')
+        end
+
+        def dashboard
+          @dashboard = Superset::Dashboard::Get.new(id)
         end
       end
     end

lib/superset/dashboard/filters/list.rb

@@ -25,6 +25,10 @@ def title
       def json_metadata
         JSON.parse(result['json_metadata'])
       end
+      
+      def filter_configuration
+        json_metadata['native_filter_configuration'] || []
+      end
 
       def positions
         JSON.parse(result['position_json'])

lib/superset/dashboard/get.rb

@@ -183,7 +183,7 @@ def new_dashboard
 
       # retrieve the datasets that will be duplicated
       def source_dashboard_datasets
-        @source_dashboard_datasets ||= Superset::Dashboard::Datasets::List.new(source_dashboard_id, true).datasets_details
+        @source_dashboard_datasets ||= Superset::Dashboard::Datasets::List.new(dashboard_id: source_dashboard_id, include_filter_datasets: true).datasets_details
       rescue => e
         raise "Unable to retrieve datasets for source dashboard #{source_dashboard_id}: #{e.message}"
       end