update validation msg

Author: jbat

lib/superset/services/duplicate_dashboard.rb

@@ -197,7 +197,7 @@ def validate_params
         # schema validations
         raise ValidationError, "Schema #{target_schema} does not exist in target database: #{target_database_id}" unless target_database_available_schemas.include?(target_schema)
         raise ValidationError, "The source dashboard datasets are required to point to one schema only. Actual schema list is #{source_dashboard_schemas.join(',')}" if source_dashboard_has_more_than_one_schema?
-        raise ValidationError, "One or more source dashboard filters point to a different dataset than the dashboard charts. Identified Unpermittied Filter Dataset Ids are #{unpermitted_filter_dataset_ids.to_s}" if unpermitted_filter_dataset_ids.any?
+        raise ValidationError, "One or more source dashboard filters point to a different schema than the dashboard charts. Identified Unpermittied Filter Dataset Ids are #{unpermitted_filter_dataset_ids.to_s}" if unpermitted_filter_dataset_ids.any?
 
         # new dataset validations
         raise ValidationError, "DATASET NAME CONFLICT: The Target Schema #{target_schema} already has existing datasets named: #{target_schema_matching_dataset_names.join(',')}" unless target_schema_matching_dataset_names.empty?

spec/superset/services/duplicate_dashboard_spec.rb

@@ -299,7 +299,7 @@
           expect(Superset::Dataset::Get).to receive(:new).with(invalid_filter_dataset_id).and_return(double(schema: invalid_filter_dataset_schema))
 
           expect { subject.perform }.to raise_error(Superset::Request::ValidationError,
-            "One or more source dashboard filters point to a different dataset than the dashboard charts. " \
+            "One or more source dashboard filters point to a different schema than the dashboard charts. " \
             "Identified Unpermittied Filter Dataset Ids are " \
             "[{:filter_dataset_id=>#{invalid_filter_dataset_id}, :filter_schema=>\"#{invalid_filter_dataset_schema}\"}]")
         end
@@ -319,7 +319,7 @@
           expect(Superset::Dataset::Get).to receive(:new).with(invalid_filter_dataset_id_2).and_return(double(schema: invalid_filter_dataset_schema_2))
 
           expect { subject.perform }.to raise_error(Superset::Request::ValidationError,
-            "One or more source dashboard filters point to a different dataset than the dashboard charts. " \
+            "One or more source dashboard filters point to a different schema than the dashboard charts. " \
             "Identified Unpermittied Filter Dataset Ids are " \
             "[{:filter_dataset_id=>#{invalid_filter_dataset_id}, :filter_schema=>\"#{invalid_filter_dataset_schema}\"}, " \
             "{:filter_dataset_id=>#{invalid_filter_dataset_id_2}, :filter_schema=>\"#{invalid_filter_dataset_schema_2}\"}]")