Adding validations for rls_clause

Author: soundarya-mv

lib/superset/guest_token.rb

@@ -11,6 +11,7 @@ def initialize(embedded_dashboard_id: , current_user: nil, rls_clause: [])
     end
 
     def guest_token
+      validate_params
       response_body['token']
     end
 
@@ -21,13 +22,17 @@ def params
             "id": embedded_dashboard_id.to_s,
             "type": "dashboard" }
         ],
-        "rls": rls_clause || [], # Ex: [{ "clause": "publisher = 'Nintendo'" }]
+        "rls": rls_clause, # Ex: [{ "clause": "publisher = 'Nintendo'" }]
         "user": current_user_params
       }
     end
 
     private
 
+    def validate_params
+      raise Superset::Request::InvalidParameterError, "rls_clause should be an array. But it is #{rls_clause.class}" if rls_clause.nil? || rls_clause.class != Array
+    end
+
     # optional param to be available in Superset for query templating using jinja
     # ss expects username .. which could be used to query as current_user.id
     def current_user_params

spec/superset/guest_token_spec.rb

@@ -14,6 +14,23 @@
     it 'returns the guest token from the response' do
       expect(subject.guest_token).to eq('some-token')
     end
+
+    context 'when invalid rls clause is passed' do
+      before { allow(subject).to receive(:rls_clause).and_return(rls_clause) }
+      context 'when rls_clause is nil' do
+        let(:rls_clause) { nil }
+        it 'raises invalid parameter error' do
+          expect{ subject.guest_token }.to raise_error(Superset::Request::InvalidParameterError, 'rls_clause should be an array. But it is NilClass')
+        end
+      end
+
+      context 'when rls_clause is not an array' do
+        let(:rls_clause) { { "clause": "publisher = 'Nintendo'" } }
+        it 'raises invalid parameter error' do
+          expect{ subject.guest_token }.to raise_error(Superset::Request::InvalidParameterError, "rls_clause should be an array. But it is Hash")
+        end
+      end
+    end
   end
 
   describe '#params' do
@@ -75,5 +92,24 @@
         )
       end
     end
+
+    context 'with rls clause as empty array' do
+      before { allow(subject).to receive(:rls_clause).and_return(rls_clause) }
+      let(:user) { nil }
+      let(:rls_clause) { [] }
+      specify do
+        expect(subject.params).to eq(
+          {
+            "resources": [
+              {
+                "id": ss_dashboard_id,
+                "type": "dashboard" }
+            ],
+            "rls": [],
+            "user": { }
+          }
+        )
+      end
+    end
   end
 end