adjust order by parms to not have a default

Author: jbat

lib/superset/dashboard/list.rb

@@ -86,6 +86,10 @@ def ids_not_in_filters
         ids_not_in.map {|id| "(col:id,opr:neq,value:'#{id}')"}.join(',')
       end
 
+      def order_by
+        ",order_column:changed_on,order_direction:desc"
+      end
+
       def list_attributes
         [:id, :dashboard_title, :status, :url]
       end

lib/superset/request.rb

@@ -36,11 +36,6 @@ def query_params
       [filters, pagination, order_by].join
     end
 
-    def order_by
-      # by default, we will order by changed_on as per the GUI
-      ",order_column:changed_on,order_direction:desc"
-    end
-
     private
 
     def route
@@ -59,6 +54,13 @@ def pagination
       "page:#{page_num},page_size:#{PAGE_SIZE}"
     end
 
+    def order_by
+      # order options are to not be consistant across all objects
+      # eg changed_on is NOT available on all objects .. requires customization in each ::List class
+      #
+      # Example only: ",order_column:changed_on,order_direction:desc"
+    end
+
     def filters
       ""
     end

spec/superset/chart/list_spec.rb

@@ -74,12 +74,10 @@
       "viz_type"=>"dist_bar"
     }]
   end
-  let(:default_query_params) { "page:0,page_size:100,order_column:changed_on,order_direction:desc" }
+  let(:default_query_params) { "page:0,page_size:100" }
 
   before do
     allow(subject).to receive(:result).and_return(result)
-    #allow(subject).to receive(:superset_host).and_return(superset_host)
-    #allow(subject).to receive(:response).and_return( { 'count': 2 } )
   end
 
   describe '#rows' do

spec/superset/database/list_spec.rb

@@ -20,7 +20,7 @@
       ]
     }
   end
-  let(:default_query_params) { "page:0,page_size:100,order_column:changed_on,order_direction:desc" }
+  let(:default_query_params) { "page:0,page_size:100" }
 
   describe '#rows' do
     before do

spec/superset/dataset/list_spec.rb

@@ -43,7 +43,7 @@
   ]
   end
 
-  let(:default_query_params) { "page:0,page_size:100,order_column:changed_on,order_direction:desc" }
+  let(:default_query_params) { "page:0,page_size:100" }
 
   before do
     allow(subject).to receive(:result).and_return(result)

spec/superset/request_spec.rb

@@ -41,7 +41,7 @@
 
   describe '#query_params' do
     it 'returns the default query params' do
-      expect(subject.send(:query_params)).to eq("page:0,page_size:100,order_column:changed_on,order_direction:desc")
+      expect(subject.send(:query_params)).to eq("page:0,page_size:100")
     end
   end
 end

spec/superset/security/user/list_spec.rb

@@ -35,7 +35,7 @@
     }]
   end
 
-  let(:default_query_params) { "page:0,page_size:100,order_column:changed_on,order_direction:desc" }
+  let(:default_query_params) { "page:0,page_size:100" }
 
   before do
     allow(subject).to receive(:result).and_return(result)