Merge pull request #13 from rdytech/NEP-17493-duplicate-dashboards-also-create-embedded-entry

Nep 17493 duplicate dashboards also create embedded entry

Author: jbat

.gitignore

@@ -14,3 +14,6 @@ superset-*.gem
 
 # ignore local .env variables
 .env
+
+# ignore local log file
+log/superset-client.log

lib/loggers/duplicate_dashboard_logger.rb

@@ -0,0 +1,15 @@
+module Superset
+  module DuplicateDashboardLogger
+   
+    
+    def logger
+      @logger ||= begin
+        if defined?(Rails)
+          Rails.try(:logger) || Logger.new(STDOUT)
+        else
+          Logger.new(STDOUT)
+        end
+      end
+    end
+  end
+end

lib/superset.rb

@@ -6,6 +6,7 @@
 require_relative "superset/authenticator"
 require_relative "superset/client"
 require_relative "superset/display"
+require_relative "superset/logger"
 require_relative "superset/request"
 
 require_rel "superset"

lib/superset/dashboard/copy.rb

@@ -18,7 +18,7 @@ def perform
         raise "Error: duplicate_slices must be a boolean" unless duplicate_slices_is_boolean?
 
         response
-        self
+        Superset::Dashboard::Get.new(id).perform  # return the full new dashboard object
       end
 
       def params

lib/superset/dashboard/embedded/get.rb

@@ -54,4 +54,3 @@ def title
     end
   end
 end
-

lib/superset/dashboard/embedded/put.rb

@@ -0,0 +1,32 @@
+module Superset
+  module Dashboard
+    module Embedded
+      class Put < Superset::Request
+        attr_reader :dashboard_id, :embedded_domain
+
+        def initialize(dashboard_id: , embedded_domain: )
+          @dashboard_id = dashboard_id
+          @embedded_domain = embedded_domain
+        end
+
+        def response
+          @response ||= client.put(route, params)
+        end
+
+        def params
+          { "allowed_domains": [embedded_domain] }
+        end
+
+        def uuid
+          result['uuid'] unless response[:result].empty?
+        end
+
+        private
+
+        def route
+          "dashboard/#{dashboard_id}/embedded"
+        end
+      end
+    end
+  end
+end

lib/superset/dashboard/get.rb

@@ -12,6 +12,11 @@ def self.call(id)
         self.new(id).list
       end
 
+      def perform
+        response
+        self
+      end
+
       def title
         "#{result['dashboard_title']}"
       end

lib/superset/dataset/duplicate.rb

@@ -16,6 +16,8 @@ def perform
         raise "Error: source_dataset_id integer is required" unless source_dataset_id.present? && source_dataset_id.is_a?(Integer)
         raise "Error: new_dataset_name string is required" unless new_dataset_name.present? && new_dataset_name.is_a?(String)
         raise "Error: new_dataset_name already in use" if new_dataset_name_already_in_use?
+
+        logger.info("  Start Duplicate Source Dataset Id: #{source_dataset_id} to New Dataset Name: #{new_dataset_name}")
 
         new_dataset_id
       end
@@ -39,7 +41,13 @@ def new_dataset_name_already_in_use?
       end
 
       def new_dataset_id
-        response["id"]
+        if response["id"].present?
+          logger.info("  Finish Duplicate Dataset. New Dataset Id: #{response['id']}")
+          response["id"]
+        else
+          logger.error("Error: Unable to duplicate dataset: #{response}")
+          raise "Error: Unable to duplicate dataset: #{response}"
+        end
       end
 
       def route

lib/superset/logger.rb

@@ -0,0 +1,18 @@
+module Superset
+  class Logger
+    
+    def info(msg)
+      logger.info(msg)
+    end
+
+    def error(msg)
+      logger.error(msg)
+    end
+
+    def logger
+      @logger ||= begin
+        ::Logger.new("log/superset-client.log")
+      end
+    end
+  end
+end

lib/superset/request.rb

@@ -3,6 +3,8 @@ class Request
     include Display
 
     class InvalidParameterError < StandardError; end
+    class ValidationError < StandardError; end
+
 
     PAGE_SIZE = 100
 
@@ -12,16 +14,15 @@ def initialize(page_num: 0)
       @page_num = page_num
     end
 
-    def logger
-      @logger ||= Logger.new('superset-api.log')
-    end
-
     def self.call
       self.new.response
     end
 
     def response
       @response ||= client.get(route)
+    rescue => e
+      logger.error("#{e.message}")
+      raise e
     end
 
     def result
@@ -53,5 +54,9 @@ def pagination
     def filters
       ""
     end
+
+    def logger
+      @logger ||= Superset::Logger.new
+    end
   end
 end