AC-11246 add chart put endpoint

Author: jbat

lib/superset/chart/put.rb

@@ -0,0 +1,39 @@
+# Updates a chart in Superset with the given params
+#
+# Usage:
+# params = { owners: [ 58, 3 ] }
+# Superset::Chart::Put.new(chart_id: 3998, params: params ).perform
+
+module Superset
+  module Chart
+    class Put < Superset::Request
+
+      attr_reader :chart_id, :params
+
+      def initialize(chart_id: , params:)
+        @chart_id = chart_id
+        @params = params
+      end
+
+      def perform
+        validate_proposed_changes
+        response
+      end
+
+      def response
+        @response ||= client.put(route, params)
+      end
+
+      private
+
+      def validate_proposed_changes
+        raise "Error: chart_id integer is required" unless chart_id.present? && chart_id.is_a?(Integer)
+        raise "Error: params hash is required" unless params.present? && params.is_a?(Hash)
+      end
+
+      def route
+        "chart/#{chart_id}"
+      end
+    end
+  end
+end

lib/superset/chart/update_dataset.rb

@@ -43,7 +43,7 @@ def params_updated
             new_params.merge!("query_context": query_context.to_json) # update to point to the new query context
             new_params.merge!("query_context_generation": true)            # new param set to true to regenerate the query context
           end
-         
+
           new_params
         end
       end

spec/superset/chart/put_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+RSpec.describe Superset::Chart::Put do
+  subject { described_class.new(
+              chart_id:  chart_id,
+              params: params) }
+
+  let(:chart_id) { 226 }
+  let(:params) { { owners: [ 1, 2, 3 ] } }
+  let(:response) do
+    {
+      id: chart_id, 
+      result: { owners: [1, 2, 3] }
+    }
+  end
+
+  before do
+    allow(subject).to receive(:response).and_return(response)
+  end
+
+  describe '#perform' do
+    context 'with valid params' do
+      specify do
+        expect(subject.perform).to eq response
+      end
+    end
+
+    context 'with invalid params' do
+      context 'chart_id is empty' do
+        let(:chart_id) { nil }
+        
+        specify do
+          expect { subject.perform }.to raise_error(RuntimeError, "Error: chart_id integer is required")
+        end
+      end
+
+      context 'params is empty' do
+        let(:params) { nil }
+        
+        specify do
+          expect { subject.perform }.to raise_error(RuntimeError, "Error: params hash is required")
+        end
+      end 
+    end
+  end
+end