Making the code generic and adding specs

Author: soundarya-mv

lib/superset/guest_token.rb

@@ -2,13 +2,12 @@ module Superset
   class GuestToken
     include Credential::EmbeddedUser
 
-    attr_accessor :embedded_dashboard_id, :current_user, :current_user_sites, :current_user_programmes
+    attr_accessor :embedded_dashboard_id, :current_user, :rls_clause
 
-    def initialize(embedded_dashboard_id: , current_user: nil, current_user_sites: [], current_user_programmes: [])
+    def initialize(embedded_dashboard_id: , current_user: nil, rls_clause: [])
       @embedded_dashboard_id = embedded_dashboard_id
       @current_user = current_user
-      @current_user_sites = current_user_sites
-      @current_user_programmes = current_user_programmes
+      @rls_clause = rls_clause
     end
 
     def guest_token
@@ -22,11 +21,7 @@ def params
             "id": embedded_dashboard_id.to_s,
             "type": "dashboard" }
         ],
-        "rls": [
-          { 
-            "clause": rls_filter_clause
-          }
-        ],
+        "rls": rls_clause || [], # Ex: [{ "clause": "publisher = 'Nintendo'" }]
         "user": current_user_params
       }
     end
@@ -71,18 +66,5 @@ def access_token
     def authenticator
       @authenticator ||= Superset::Authenticator.new(credentials)
     end
-
-    def rls_filter_clause
-      "#{site_clause} AND #{programme_clause}"
-    end
-
-    def site_clause
-      return true if current_user_sites.empty?
-      "site_id = ANY(ARRAY[#{current_user_sites}])" 
-    end
-
-    def programme_clause
-      "programme = ANY(string_to_array(replace(trim(('#{current_user_programmes.to_json}'), '[]'), '\"', ''), ','))"
-    end
   end
 end

spec/superset/guest_token_spec.rb

@@ -56,5 +56,24 @@
         )
       end
     end
+
+    context 'with rls clause' do
+      before { allow(subject).to receive(:rls_clause).and_return(rls_clause) }
+      let(:user) { nil }
+      let(:rls_clause) { [{ "clause": "publisher = 'Nintendo'" }] }
+      specify do
+        expect(subject.params).to eq(
+          {
+            "resources": [
+              {
+                "id": ss_dashboard_id,
+                "type": "dashboard" }
+            ],
+            "rls": rls_clause,
+            "user": { }
+          }
+        )
+      end
+    end
   end
 end