Skip to content

Commit c9f5062

Browse files
committed
Adding spec changes
1 parent 39f62d7 commit c9f5062

File tree

1 file changed

+35
-34
lines changed

1 file changed

+35
-34
lines changed

spec/superset/guest_token_spec.rb

Lines changed: 35 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -34,49 +34,51 @@
3434
end
3535

3636
describe '#params' do
37-
before do
38-
allow(subject).to receive(:current_user).and_return(user)
39-
end
37+
context "with additional params" do
38+
before do
39+
allow(subject).to receive(:additional_params).and_return(additional_params)
40+
end
4041

41-
context 'without a current_user' do
42-
let(:user) { nil }
42+
context 'without a current_user' do
43+
let(:additional_params) { {} }
4344

44-
specify do
45-
expect(subject.params).to eq(
46-
{
47-
"resources": [
48-
{
49-
"id": ss_dashboard_id,
50-
"type": "dashboard" }
51-
],
52-
"rls": [],
53-
"user": { }
54-
}
55-
)
45+
specify do
46+
expect(subject.params).to eq(
47+
{
48+
"resources": [
49+
{
50+
"id": ss_dashboard_id,
51+
"type": "dashboard" }
52+
],
53+
"rls": [],
54+
"user": { }
55+
}
56+
)
57+
end
5658
end
57-
end
5859

59-
context 'with a current_user' do
60-
let(:user) { double(id: 101) }
60+
context 'with a current_user' do
61+
let(:additional_params) { {embedded_app_current_user_id: 1} }
6162

62-
specify 'passes user id to superset' do
63-
expect(subject.params).to eq(
64-
{
65-
"resources": [
66-
{
67-
"id": ss_dashboard_id,
68-
"type": "dashboard" }
69-
],
70-
"rls": [],
71-
"user": { username: "101" }
72-
}
73-
)
63+
specify 'passes user id to superset' do
64+
expect(subject.params).to eq(
65+
{
66+
"resources": [
67+
{
68+
"id": ss_dashboard_id,
69+
"type": "dashboard" }
70+
],
71+
"rls": [],
72+
"user": { username: additional_params[:embedded_app_current_user_id].to_s },
73+
"embedded_app_current_user_id": additional_params[:embedded_app_current_user_id]
74+
}
75+
)
76+
end
7477
end
7578
end
7679

7780
context 'with rls clause' do
7881
before { allow(subject).to receive(:rls_clause).and_return(rls_clause) }
79-
let(:user) { nil }
8082
let(:rls_clause) { [{ "clause": "publisher = 'Nintendo'" }] }
8183
specify do
8284
expect(subject.params).to eq(
@@ -95,7 +97,6 @@
9597

9698
context 'with rls clause as empty array' do
9799
before { allow(subject).to receive(:rls_clause).and_return(rls_clause) }
98-
let(:user) { nil }
99100
let(:rls_clause) { [] }
100101
specify do
101102
expect(subject.params).to eq(

0 commit comments

Comments
 (0)