adds spec and fixture for export process

Author: jbat

.gitignore

@@ -17,3 +17,6 @@ superset-*.gem
 
 # ignore local log file
 log/superset-client.log
+
+# ignore local ./tmp directory
+./tmp/

lib/superset/dashboard/export.rb

@@ -18,13 +18,13 @@ class Export < Request
 
       def initialize(dashboard_id: , destination_path: )
         @dashboard_id = dashboard_id
-        @destination_path = destination_path
-        @download_path = TMP_SUPERSET_DASHBOARD_PATH
+        @destination_path = destination_path.chomp('/')
       end
 
       def perform
-        response
-        write_file_and_unzip
+        create_tmp_dir
+        save_exported_zip_file
+        unzip_files
         copy_export_files_to_destination_path if destination_path
       end
 
@@ -43,18 +43,15 @@ def download_folder
 
       private
 
-      def route
-        "dashboard/export/"
-      end
-
       def params
         { "q": "!(#{dashboard_id})" }   # pulled off chrome dev tools doing a GUI export.  Swagger interface not helpfull with this endpoint.
       end
 
-      def write_file_and_unzip
-        create_tmp_dir
-        File.open(zip_file_name, 'wb') { |fp| fp.write(@response.body) }
+      def save_exported_zip_file
+        File.open(zip_file_name, 'wb') { |fp| fp.write(response.body) }
+      end
 
+      def unzip_files
         @extracted_files = unzip_file(zip_file_name, tmp_uniq_dashboard_path)
       end
 
@@ -89,6 +86,10 @@ def extracted_files
         @extracted_files ||= []
       end
 
+      def route
+        "dashboard/export/"
+      end
+
       def datestamp
         @datestamp ||= Time.now.strftime('%Y%m%d')
       end

spec/fixtures/dashboard_18_export_20240322.zip

@@ -0,0 +1,39 @@
+require 'spec_helper'
+
+RSpec.describe Superset::Dashboard::Export do
+  subject { described_class.new(dashboard_id: dashboard_id, destination_path: destination_path) }
+  let(:dashboard_id) { 18 }
+  let(:destination_path) { './tmp/superset_dashboard_backups/' }
+
+  describe '#perform' do
+    let(:response) { double('response') }
+    let(:zip_file_name) { 'spec/fixtures/dashboard_18_export_20240322.zip' } # example birth names dashboard export fixture
+
+    before do
+      allow(subject).to receive(:response).and_return(response)
+      allow(subject).to receive(:zip_file_name).and_return(zip_file_name)
+      allow(subject).to receive(:save_exported_zip_file)
+    end
+
+    it 'unzips into the destination path' do
+      subject.perform
+      expect(Dir.glob(subject.destination_path + "/**/*").sort).to match_array([
+        "./tmp/superset_dashboard_backups/18",
+        "./tmp/superset_dashboard_backups/18/charts",
+        "./tmp/superset_dashboard_backups/18/charts/Boy_Name_Cloud_53920.yaml",
+        "./tmp/superset_dashboard_backups/18/charts/Names_Sorted_by_Num_in_California_53929.yaml",
+        "./tmp/superset_dashboard_backups/18/charts/Number_of_Girls_53930.yaml",
+        "./tmp/superset_dashboard_backups/18/charts/Pivot_Table_53931.yaml",
+        "./tmp/superset_dashboard_backups/18/charts/Top_10_Girl_Name_Share_53921.yaml",
+        "./tmp/superset_dashboard_backups/18/dashboards",
+        "./tmp/superset_dashboard_backups/18/dashboards/Birth_Names_18.yaml",
+        "./tmp/superset_dashboard_backups/18/databases",
+        "./tmp/superset_dashboard_backups/18/databases/examples.yaml",
+        "./tmp/superset_dashboard_backups/18/datasets",
+        "./tmp/superset_dashboard_backups/18/datasets/examples",
+        "./tmp/superset_dashboard_backups/18/datasets/examples/birth_names.yaml",
+        "./tmp/superset_dashboard_backups/18/metadata.yaml"
+      ])
+    end
+  end
+end