Skip to content

Commit f495d07

Browse files
committed
[NEP-18619]: Removing existing dataset validation
1 parent 8b22686 commit f495d07

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

lib/superset/services/duplicate_dashboard.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -203,8 +203,8 @@ def validate_params
203203
raise ValidationError, "The source dashboard datasets are required to point to one schema only. Actual schema list is #{source_dashboard_schemas.join(',')}" if source_dashboard_has_more_than_one_schema?
204204
raise ValidationError, "One or more source dashboard filters point to a different schema than the dashboard charts. Identified Unpermittied Filter Dataset Ids are #{unpermitted_filter_dataset_ids.to_s}" if unpermitted_filter_dataset_ids.any?
205205

206-
# new dataset validations
207-
raise ValidationError, "DATASET NAME CONFLICT: The Target Schema #{target_schema} already has existing datasets named: #{target_schema_matching_dataset_names.join(',')}" unless target_schema_matching_dataset_names.empty?
206+
# new dataset validations - Need to remove this as we are using the existing datasets for the new dashboard
207+
# raise ValidationError, "DATASET NAME CONFLICT: The Target Schema #{target_schema} already has existing datasets named: #{target_schema_matching_dataset_names.join(',')}" unless target_schema_matching_dataset_names.empty?
208208
validate_source_dashboard_datasets_sql_does_not_hard_code_schema
209209

210210
# embedded allowed_domain validations

0 commit comments

Comments
 (0)