Skip to content

Commit 153c4e5

Browse files
committed
Merge remote-tracking branch 'origin' into input-binding
2 parents 30f81e5 + c0c08fd commit 153c4e5

File tree

10 files changed

+271
-250
lines changed

10 files changed

+271
-250
lines changed

.Rbuildignore

Lines changed: 9 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,20 +1,19 @@
1-
^Meta$
2-
^doc$
1+
^node_modules$
2+
^js-tests$
3+
^srcjs$
4+
^pkgdown$
5+
^assets$
36
^.*\.Rproj$
47
^CONDUCT\.md$
58
^README\.Rmd$
69
^\.Rproj\.user$
710
^\.travis\.yml$
8-
^assets
9-
^build
10-
^docs
11-
^js-tests
12-
^node_modules
13-
^pkgdown
14-
^srcjs
11+
^build$
12+
^docs$
1513
^cran-comments\.md$
1614
^karma\.conf\.js$
1715
^logo.svg$
1816
^package\.json$
19-
^webpack.config.js$
17+
^webpack\.config\.js$
2018
^yarn\.lock$
19+
^logo\.svg$

NEWS.md

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,11 @@
11
# reactR 0.3.1
22

3-
* Add `usethis` dependency
3+
* Update react and react-dom to 16.8.1
4+
* Add `usethis` R dependency
45
* Ignore node_modules in `.Rbuildignore` and `.gitignore`
6+
* Set `{modules:false}` in `babel_transform` to avoid `"use strict"`; [pull 15](https://github.com/react-R/reactR/pull/15)
7+
* Use webpack to build `react-tools.js`; [pull 16](https://github.com/react-R/reactR/pull/16)
8+
* Attach component to the htmlwidget
59

610
# reactR 0.3.0
711

R/meta.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
#'@keywords internal
2-
react_version <- function(){'16.7.0'}
2+
react_version <- function(){'16.8.1'}
33
babel_version <- function(){'6.26.0'}

R/reacttools.R

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@ React <- structure(
7777
#' Prepare data that represents a single-element character vector, a React
7878
#' component, or an htmltools tag for sending to the client.
7979
#'
80-
#' Tag lists as returned by \code{\link[htmltools]{tagList}} are not currently
80+
#' Tag lists as returned by \code{htmltools tagList} are not currently
8181
#' supported.
8282
#'
8383
#' @param tag character vector or React component or

inst/templates/widget_r.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@ ${name} <- function(message, width = NULL, height = NULL, elementId = NULL) {
3838
#' @name ${name}-shiny
3939
#'
4040
#' @export
41-
${name}Output <- function(outputId, width = '100%%', height = '400px'){
41+
${name}Output <- function(outputId, width = '100%', height = '400px'){
4242
htmlwidgets::shinyWidgetOutput(outputId, '${name}', width, height, package = '${package}')
4343
}
4444

@@ -57,6 +57,6 @@ ${name}_html <- function(id, style, class, ...) {
5757
reactR::html_dependency_corejs(),
5858
reactR::html_dependency_react(),
5959
reactR::html_dependency_reacttools(),
60-
htmltools::tags$div(id = id, class = class)
60+
htmltools::tags$div(id = id, class = class, style = style)
6161
)
6262
}

inst/www/react/react-dom.min.js

Lines changed: 207 additions & 195 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

inst/www/react/react.min.js

Lines changed: 25 additions & 24 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

man/reactMarkup.Rd

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1,23 +1,23 @@
11
{
22
"devDependencies": {
3+
"@babel/core": "^7.2.2",
4+
"@babel/preset-env": "^7.3.1",
5+
"@babel/preset-react": "^7.0.0",
6+
"@rgrove/parse-xml": "^1.1.1",
7+
"babel-loader": "^8.0.5",
38
"chai": "^4.2.0",
49
"karma": "^3.1.4",
510
"karma-chai": "^0.1.0",
611
"karma-chrome-launcher": "^2.2.0",
712
"karma-mocha": "^1.3.0",
8-
"karma-webpack": "^4.0.0-rc.6",
913
"karma-source-map-support": "^1.3.0",
14+
"karma-webpack": "^4.0.0-rc.6",
1015
"mocha": "^5.2.0",
11-
"react": "^16.7.0",
12-
"react-dom": "^16.7.0",
16+
"react": "^16.8.1",
17+
"react-dom": "^16.8.1",
18+
"react-html-parser": "^2.0.2",
1319
"webpack": "^4.27.1",
14-
"webpack-cli": "^3.1.2",
15-
"@babel/core": "^7.2.2",
16-
"babel-loader": "^8.0.5",
17-
"@babel/preset-env": "^7.3.1",
18-
"@babel/preset-react": "^7.0.0",
19-
"@rgrove/parse-xml": "^1.1.1",
20-
"react-html-parser": "^2.0.2"
20+
"webpack-cli": "^3.1.2"
2121
},
2222
"scripts": {
2323
"test": "karma start --single-run --browsers ChromeHeadless karma.conf.js"

yarn.lock

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2954,7 +2954,7 @@ log4js@^3.0.0:
29542954
rfdc "^1.1.2"
29552955
streamroller "0.7.0"
29562956

2957-
loose-envify@^1.0.0, loose-envify@^1.1.0, loose-envify@^1.3.1:
2957+
loose-envify@^1.0.0, loose-envify@^1.1.0:
29582958
version "1.4.0"
29592959
resolved "https://registry.yarnpkg.com/loose-envify/-/loose-envify-1.4.0.tgz#71ee51fa7be4caec1a63839f7e682d8132d30caf"
29602960
integrity sha512-lyuxPGr/Wfhrlem2CL/UcnUc1zcqKAImBDzukY7Y5F/yQiNdko6+fRLevlw1HgMySw7f611UIY408EtxRSoK3Q==
@@ -3629,12 +3629,12 @@ promise-inflight@^1.0.1:
36293629
integrity sha1-mEcocL8igTL8vdhoEputEsPAKeM=
36303630

36313631
prop-types@^15.6.2:
3632-
version "15.6.2"
3633-
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.6.2.tgz#05d5ca77b4453e985d60fc7ff8c859094a497102"
3634-
integrity sha512-3pboPvLiWD7dkI3qf3KbUe6hKFKa52w+AE0VCqECtf+QHAKgOL37tTaNCnuX1nAAQ4ZhyP+kYVKf8rLmJ/feDQ==
3632+
version "15.7.1"
3633+
resolved "https://registry.yarnpkg.com/prop-types/-/prop-types-15.7.1.tgz#2fa61e0a699d428b40320127733ee2931f05d9d1"
3634+
integrity sha512-f8Lku2z9kERjOCcnDOPm68EBJAO2K00Q5mSgPAUE/gJuBgsYLbVy6owSrtcHj90zt8PvW+z0qaIIgsIhHOa1Qw==
36353635
dependencies:
3636-
loose-envify "^1.3.1"
36373636
object-assign "^4.1.1"
3637+
react-is "^16.8.1"
36383638

36393639
prr@~1.0.1:
36403640
version "1.0.1"
@@ -3775,6 +3775,11 @@ react-html-parser@^2.0.2:
37753775
dependencies:
37763776
htmlparser2 "^3.9.0"
37773777

3778+
react-is@^16.8.1:
3779+
version "16.8.1"
3780+
resolved "https://registry.yarnpkg.com/react-is/-/react-is-16.8.1.tgz#a80141e246eb894824fb4f2901c0c50ef31d4cdb"
3781+
integrity sha512-ioMCzVDWvCvKD8eeT+iukyWrBGrA3DiFYkXfBsVYIRdaREZuBjENG+KjrikavCLasozqRWTwFUagU/O4vPpRMA==
3782+
37783783
react@^16.7.0:
37793784
version "16.8.1"
37803785
resolved "https://registry.yarnpkg.com/react/-/react-16.8.1.tgz#ae11831f6cb2a05d58603a976afc8a558e852c4a"

0 commit comments

Comments
 (0)