Skip to content

Commit 1d873d1

Browse files
add cran comments
1 parent 2c973c6 commit 1d873d1

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

cran-comments.md

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,11 @@
1+
## Comments
2+
3+
**Resubmission**
4+
5+
1. Changed license to MIT to mirror change to MIT by Facebook/React
6+
2. "React" should now be all uppercase
7+
3. Do not want to add executable `babel_transform` example since many users do not use and do not want to have to install `V8`. Use of `V8` also makes testing difficult. However, it can be a very powerful tool when using with React, so I most definitely want to keep `babel_transform`.
8+
19
## Test environments
210
* local Windows 10 install, R 3.4.0
311
* rhub check_for_cran

0 commit comments

Comments
 (0)