Constrain names allowed for scaffolded inputs and widgets

Author: alandipert

R/scaffold_input.R

@@ -16,6 +16,7 @@
 #'
 #' @export
 scaffoldReactShinyInput <- function(name, npmPkgs = NULL, edit = interactive()) {
+  assertNameValid(name)
   package <- getPackage()
 
   file <- renderFile(

R/scaffold_utils.R

@@ -52,3 +52,16 @@ getPackage <- function() {
   }
   read.dcf('DESCRIPTION')[[1,"Package"]]
 }
+
+validName <- function(name) {
+  grepl("^[[:alpha:]]+[[:alnum:]]*$", name)
+}
+
+# Constraining names prevents the user from encountering obscure CSS problems
+# and JavaScript errors after scaffolding.
+assertNameValid <- function(name) {
+  if (!validName(name)) {
+    msg <- sprintf("Name '%s' is invalid, names must begin with an alphabetic character and must contain only alphabetic and numeric characters", name)
+    stop(msg, call. = FALSE)
+  }
+}

R/scaffold_widget.R

@@ -16,6 +16,7 @@
 #'
 #' @export
 scaffoldReactWidget <- function(name, npmPkgs = NULL, edit = interactive()){
+  assertNameValid(name)
   package <- getPackage()
 
   addWidgetConstructor(name, package, edit)