Restrict name strings in scaffolding to avoid subsequent problems

Author: alandipert

R/reacttools.R

@@ -1,3 +1,9 @@
+# A robust name string is a valid
+# - CSS class
+# - JavaScript variable name
+# - R variable name
+robustName <- "^[[:alpha:]_][[:alnum:]_]*$"
+
 isUpper <- function(s) {
   grepl("^[[:upper:]]+$", s)
 }

R/scaffold_utils.R

@@ -53,14 +53,10 @@ getPackage <- function() {
   read.dcf('DESCRIPTION')[[1,"Package"]]
 }
 
-validName <- function(name) {
-  grepl("^[[:alpha:]_][[:alnum:]_]*$", name)
-}
-
 # Constraining names prevents the user from encountering obscure CSS problems
 # and JavaScript errors after scaffolding.
 assertNameValid <- function(name) {
-  if (!validName(name)) {
+  if (!grepl(robustName, name)) {
     msg <- sprintf("Name '%s' is invalid, names must begin with an alphabetic character and must contain only alphabetic and numeric characters", name)
     stop(msg, call. = FALSE)
   }