Skip to content
This repository was archived by the owner on Nov 6, 2025. It is now read-only.

Commit 53ff8de

Browse files
authored
chore: 🔧 releasing 1.2.5
2 parents c339c1e + dc7a463 commit 53ff8de

File tree

9 files changed

+102
-71
lines changed

9 files changed

+102
-71
lines changed

.all-contributorsrc

Lines changed: 11 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,17 @@
5050
"contributions": [
5151
"doc"
5252
]
53+
},
54+
{
55+
"login": "rejochandran",
56+
"name": "Rejo Chandran",
57+
"avatar_url": "https://avatars.githubusercontent.com/u/4696985?v=4",
58+
"profile": "https://github.com/rejochandran",
59+
"contributions": [
60+
"code",
61+
"doc",
62+
"test"
63+
]
5364
}
5465
],
5566
"contributorsPerLine": 8,

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -135,6 +135,7 @@ But wait... there's more!
135135
<td align="center"><a href="https://github.com/receptiryaki"><img src="https://avatars0.githubusercontent.com/u/3495307?s=80" width="80px;" alt=""/><br /><sub><b>Recep Tiryaki</b></sub></a><br /><a href="https://github.com/react-boilerplate/react-boilerplate-cra-template/commits?author=receptiryaki" title="Code">💻</a> <a href="#ideas-receptiryaki" title="Ideas, Planning, & Feedback">🤔</a> <a href="#design-receptiryaki" title="Design">🎨</a></td>
136136
<td align="center"><a href="https://github.com/mogsdad"><img src="https://avatars3.githubusercontent.com/u/1707731?s=80" width="80px;" alt=""/><br /><sub><b>David Bingham</b></sub></a><br /><a href="https://github.com/react-boilerplate/react-boilerplate-cra-template/commits?author=mogsdad" title="Documentation">📖</a></td>
137137
<td align="center"><a href="https://github.com/lourensdev"><img src="https://avatars.githubusercontent.com/u/5746141?v=4?s=80" width="80px;" alt=""/><br /><sub><b>Lourens de Villiers</b></sub></a><br /><a href="https://github.com/react-boilerplate/react-boilerplate-cra-template/commits?author=lourensdev" title="Documentation">📖</a></td>
138+
<td align="center"><a href="https://github.com/rejochandran"><img src="https://avatars.githubusercontent.com/u/4696985?v=4?s=80" width="80px;" alt=""/><br /><sub><b>Rejo Chandran</b></sub></a><br /><a href="https://github.com/react-boilerplate/react-boilerplate-cra-template/commits?author=rejochandran" title="Code">💻</a> <a href="https://github.com/react-boilerplate/react-boilerplate-cra-template/commits?author=rejochandran" title="Documentation">📖</a> <a href="https://github.com/react-boilerplate/react-boilerplate-cra-template/commits?author=rejochandran" title="Tests">⚠️</a></td>
138139
</tr>
139140
</table>
140141

docs/building-blocks/README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ It is one of the most important files of the boilerplate. It contains all the gl
1010

1111
- `react-app-polyfill` is imported to enable compatibility with many browsers and cool stuff like generator functions, Promises, etc.
1212
- A Redux `store` is instantiated.
13-
- `ReactDOM.render()` not only renders the [root React component](https://github.com/react-boilerplate/react-boilerplate-cra-template/blob/master/src/app/index.tsx), called `<App />`, of your application, but it renders it with `<Provider />`.
13+
- `createRoot().render()` not only renders the [root React component](https://github.com/react-boilerplate/react-boilerplate-cra-template/blob/master/src/app/index.tsx), called `<App />`, of your application, but it renders it with `<Provider />`.
1414
- Hot module replacement via [Webpack HMR](https://webpack.js.org/guides/hot-module-replacement/) makes the i18n translations hot re-loadable.
1515
- i18next internationalization support setup.
1616
- `<Provider />` connects your app with the Redux `store`.

internals/startingTemplate/src/index.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import 'react-app-polyfill/ie11';
99
import 'react-app-polyfill/stable';
1010

1111
import * as React from 'react';
12-
import * as ReactDOM from 'react-dom';
12+
import * as ReactDOMClient from 'react-dom/client';
1313
import { Provider } from 'react-redux';
1414

1515
// Use consistent styling
@@ -30,15 +30,14 @@ import './locales/i18n';
3030
const store = configureAppStore();
3131
const MOUNT_NODE = document.getElementById('root') as HTMLElement;
3232

33-
ReactDOM.render(
33+
ReactDOMClient.createRoot(MOUNT_NODE!).render(
3434
<Provider store={store}>
3535
<HelmetProvider>
3636
<React.StrictMode>
3737
<App />
3838
</React.StrictMode>
3939
</HelmetProvider>
4040
</Provider>,
41-
MOUNT_NODE,
4241
);
4342

4443
// Hot reloadable translation json files

package.json

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -93,12 +93,12 @@
9393
"fontfaceobserver": "2.1.0",
9494
"i18next": "21.6.6",
9595
"i18next-browser-languagedetector": "6.1.2",
96-
"react": "17.0.2",
96+
"react": "18.1.0",
9797
"react-app-polyfill": "3.0.0",
98-
"react-dom": "17.0.2",
98+
"react-dom": "^18.0.0",
9999
"react-helmet-async": "1.3.0",
100100
"react-i18next": "11.16.5",
101-
"react-is": "17.0.2",
101+
"react-is": "18.1.0",
102102
"react-redux": "7.2.6",
103103
"react-router-dom": "5.2.0",
104104
"redux-injectors": "1.3.0",
@@ -110,16 +110,16 @@
110110
"devDependencies": {
111111
"@commitlint/cli": "13.1.0",
112112
"@commitlint/config-conventional": "13.1.0",
113-
"@testing-library/jest-dom": "5.16.1",
114-
"@testing-library/react": "12.1.2",
113+
"@testing-library/jest-dom": "5.16.4",
114+
"@testing-library/react": "13.2.0",
115115
"@types/fontfaceobserver": "2.1.0",
116116
"@types/jest": "27.4.0",
117117
"@types/node": "14.14.31",
118118
"@types/react": "18.0.2",
119119
"@types/react-dom": "18.0.0",
120120
"@types/react-redux": "7.1.22",
121121
"@types/react-router-dom": "5.3.2",
122-
"@types/react-test-renderer": "17.0.1",
122+
"@types/react-test-renderer": "18.0.0",
123123
"@types/rimraf": "3.0.2",
124124
"@types/shelljs": "0.8.11",
125125
"@types/styled-components": "5.1.20",
@@ -144,7 +144,7 @@
144144
"plop": "2.7.4",
145145
"prettier": "2.5.1",
146146
"react-scripts": "5.0.0",
147-
"react-test-renderer": "17.0.2",
147+
"react-test-renderer": "18.1.0",
148148
"replace-in-file": "6.3.2",
149149
"rimraf": "3.0.2",
150150
"serve": "13.0.2",

src/app/pages/HomePage/Features/GithubRepoForm/__tests__/index.test.tsx

Lines changed: 21 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import * as React from 'react';
22
import { Store } from '@reduxjs/toolkit';
3-
import { render, fireEvent } from '@testing-library/react';
3+
import { render, fireEvent, waitFor } from '@testing-library/react';
44
import { Provider } from 'react-redux';
55
import { ThemeProvider } from 'styles/theme/ThemeProvider';
66
import { HelmetProvider } from 'react-helmet-async';
@@ -76,33 +76,45 @@ describe('<GithubRepoForm />', () => {
7676
expect(component.container.querySelector('circle')).toBeInTheDocument();
7777
});
7878

79-
it('should display list when repos not empty', () => {
79+
it('should display list when repos not empty', async () => {
8080
const repoName = 'testRepo';
8181
store.dispatch(
8282
actions.reposLoaded([{ id: 'test', name: repoName } as any]),
8383
);
84-
expect(component.queryByText(repoName)).toBeInTheDocument();
84+
await waitFor(() =>
85+
expect(component.queryByText(repoName)).toBeInTheDocument(),
86+
);
8587
});
8688

87-
it('should display error when repoError fired', () => {
89+
it('should display error when repoError fired', async () => {
8890
let error = RepoErrorType.USER_NOT_FOUND;
8991
store.dispatch(actions.repoError(error));
90-
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument();
92+
await waitFor(() =>
93+
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument(),
94+
);
9195

9296
error = RepoErrorType.USER_HAS_NO_REPO;
9397
store.dispatch(actions.repoError(error));
94-
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument();
98+
await waitFor(() =>
99+
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument(),
100+
);
95101

96102
error = RepoErrorType.USERNAME_EMPTY;
97103
store.dispatch(actions.repoError(error));
98-
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument();
104+
await waitFor(() =>
105+
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument(),
106+
);
99107

100108
error = RepoErrorType.RESPONSE_ERROR;
101109
store.dispatch(actions.repoError(error));
102-
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument();
110+
await waitFor(() =>
111+
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument(),
112+
);
103113

104114
error = RepoErrorType.GITHUB_RATE_LIMIT;
105115
store.dispatch(actions.repoError(error));
106-
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument();
116+
await waitFor(() =>
117+
expect(component.queryByText(repoErrorText(error))).toBeInTheDocument(),
118+
);
107119
});
108120
});

src/index.tsx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import 'react-app-polyfill/ie11';
99
import 'react-app-polyfill/stable';
1010

1111
import * as React from 'react';
12-
import * as ReactDOM from 'react-dom';
12+
import * as ReactDOMClient from 'react-dom/client';
1313
import { Provider } from 'react-redux';
1414
import FontFaceObserver from 'fontfaceobserver';
1515

@@ -41,7 +41,7 @@ openSansObserver.load().then(() => {
4141
const store = configureAppStore();
4242
const MOUNT_NODE = document.getElementById('root') as HTMLElement;
4343

44-
ReactDOM.render(
44+
ReactDOMClient.createRoot(MOUNT_NODE!).render(
4545
<Provider store={store}>
4646
<ThemeProvider>
4747
<HelmetProvider>
@@ -51,7 +51,6 @@ ReactDOM.render(
5151
</HelmetProvider>
5252
</ThemeProvider>
5353
</Provider>,
54-
MOUNT_NODE,
5554
);
5655

5756
// Hot reloadable translation json files

template.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -43,12 +43,12 @@
4343
"fontfaceobserver": "2.1.0",
4444
"i18next": "21.6.6",
4545
"i18next-browser-languagedetector": "6.1.2",
46-
"react": "17.0.2",
46+
"react": "18.1.0",
4747
"react-app-polyfill": "3.0.0",
48-
"react-dom": "17.0.2",
48+
"react-dom": "18.1.0",
4949
"react-helmet-async": "1.3.0",
5050
"react-i18next": "11.16.5",
51-
"react-is": "17.0.2",
51+
"react-is": "18.1.0",
5252
"react-redux": "7.2.6",
5353
"react-router-dom": "5.2.0",
5454
"redux-injectors": "1.3.0",
@@ -66,7 +66,7 @@
6666
"@types/react-dom": "18.0.0",
6767
"@types/react-redux": "7.1.22",
6868
"@types/react-router-dom": "5.3.2",
69-
"@types/react-test-renderer": "17.0.1",
69+
"@types/react-test-renderer": "18.0.0",
7070
"@types/rimraf": "3.0.2",
7171
"@types/shelljs": "0.8.11",
7272
"@types/styled-components": "5.1.20",
@@ -87,7 +87,7 @@
8787
"node-plop": "0.26.2",
8888
"plop": "2.7.4",
8989
"prettier": "2.5.1",
90-
"react-test-renderer": "17.0.2",
90+
"react-test-renderer": "18.1.0",
9191
"rimraf": "3.0.2",
9292
"serve": "13.0.2",
9393
"shelljs": "0.8.5",

0 commit comments

Comments
 (0)