fix: for react-testing-library to find dialog by findByRole with labe… (#290)

* fix: for react-testing-library to find dialog by findByRole with labelName as priority in rules on top of findByLabelText

* test snapshot updated

* removed unnecessary aria-labelledBy

Author: hedaukartik

src/Dialog/Content/index.tsx

@@ -142,6 +142,7 @@ const Content = React.forwardRef<ContentRef, ContentProps>((props, ref) => {
         <div
           key="dialog-element"
           role="dialog"
+          aria-labelledby={title ? ariaId : null}
           aria-modal="true"
           ref={motionRef}
           style={{ ...motionStyle, ...style, ...contentStyle }}

src/Dialog/index.tsx

@@ -29,7 +29,6 @@ export default function Dialog(props: IDialogChildProps) {
     scrollLocker,
 
     // Wrapper
-    title,
     wrapStyle,
     wrapClassName,
     wrapProps,
@@ -182,7 +181,6 @@ export default function Dialog(props: IDialogChildProps) {
         className={classNames(`${prefixCls}-wrap`, wrapClassName)}
         ref={wrapperRef}
         onClick={onWrapperClick}
-        aria-labelledby={title ? ariaId : null}
         style={{ zIndex, ...wrapStyle, display: !animatedVisible ? 'none' : null }}
         {...wrapProps}
       >

tests/__snapshots__/index.spec.tsx.snap

@@ -57,11 +57,11 @@ exports[`dialog should render correct 1`] = `
     class="rc-dialog-mask"
   />
   <div
-    aria-labelledby="test-id"
     class="rc-dialog-wrap"
     tabindex="-1"
   >
     <div
+      aria-labelledby="test-id"
       aria-modal="true"
       class="rc-dialog"
       role="dialog"