Skip to content

Commit 32c4e06

Browse files
author
刘欢
committed
feat: Call separately
1 parent 713af57 commit 32c4e06

File tree

3 files changed

+4
-20
lines changed

3 files changed

+4
-20
lines changed

src/Dialog/index.tsx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -95,9 +95,7 @@ const Dialog: React.FC<IDialogPropTypes> = (props) => {
9595

9696
// Trigger afterClose only when change visible from true to false
9797
if (animatedVisible) {
98-
const { afterClose: closableAfterClose = undefined } =
99-
typeof closable === 'object' ? closable : {};
100-
(closableAfterClose ?? afterClose)?.();
98+
afterClose?.();
10199
}
102100
}
103101

src/DialogWrap.tsx

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,8 @@ const DialogWrap: React.FC<IDialogPropTypes> = (props) => {
5252
afterClose={() => {
5353
const { afterClose: closableAfterClose = undefined } =
5454
typeof closable === 'object' ? closable : {};
55-
(closableAfterClose ?? afterClose)?.();
55+
closableAfterClose?.();
56+
afterClose?.();
5657
setAnimatedVisible(false);
5758
}}
5859
/>

tests/index.spec.tsx

Lines changed: 1 addition & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -553,21 +553,6 @@ describe('dialog', () => {
553553
expect(afterClose).toHaveBeenCalledTimes(0);
554554
});
555555

556-
it('should trigger closable.afterClose when using new API', () => {
557-
const afterClose = jest.fn();
558-
559-
const { rerender } = render(<Dialog closable={{ afterClose }} visible />);
560-
act(() => {
561-
jest.runAllTimers();
562-
});
563-
564-
rerender(<Dialog closable={{ afterClose }} visible={false} />);
565-
act(() => {
566-
jest.runAllTimers();
567-
});
568-
expect(afterClose).toHaveBeenCalledTimes(1);
569-
});
570-
571556
it('should prioritize closable.afterClose when both exist', () => {
572557
const afterClose = jest.fn();
573558
const legacyAfterClose = jest.fn();
@@ -584,7 +569,7 @@ describe('dialog', () => {
584569
jest.runAllTimers();
585570
});
586571
expect(afterClose).toHaveBeenCalledTimes(1);
587-
expect(legacyAfterClose).toHaveBeenCalledTimes(0);
572+
expect(legacyAfterClose).toHaveBeenCalledTimes(1);
588573
});
589574
});
590575

0 commit comments

Comments
 (0)