File tree Expand file tree Collapse file tree 3 files changed +4
-20
lines changed Expand file tree Collapse file tree 3 files changed +4
-20
lines changed Original file line number Diff line number Diff line change @@ -95,9 +95,7 @@ const Dialog: React.FC<IDialogPropTypes> = (props) => {
95
95
96
96
// Trigger afterClose only when change visible from true to false
97
97
if ( animatedVisible ) {
98
- const { afterClose : closableAfterClose = undefined } =
99
- typeof closable === 'object' ? closable : { } ;
100
- ( closableAfterClose ?? afterClose ) ?.( ) ;
98
+ afterClose ?.( ) ;
101
99
}
102
100
}
103
101
Original file line number Diff line number Diff line change @@ -52,7 +52,8 @@ const DialogWrap: React.FC<IDialogPropTypes> = (props) => {
52
52
afterClose = { ( ) => {
53
53
const { afterClose : closableAfterClose = undefined } =
54
54
typeof closable === 'object' ? closable : { } ;
55
- ( closableAfterClose ?? afterClose ) ?.( ) ;
55
+ closableAfterClose ?.( ) ;
56
+ afterClose ?.( ) ;
56
57
setAnimatedVisible ( false ) ;
57
58
} }
58
59
/>
Original file line number Diff line number Diff line change @@ -553,21 +553,6 @@ describe('dialog', () => {
553
553
expect ( afterClose ) . toHaveBeenCalledTimes ( 0 ) ;
554
554
} ) ;
555
555
556
- it ( 'should trigger closable.afterClose when using new API' , ( ) => {
557
- const afterClose = jest . fn ( ) ;
558
-
559
- const { rerender } = render ( < Dialog closable = { { afterClose } } visible /> ) ;
560
- act ( ( ) => {
561
- jest . runAllTimers ( ) ;
562
- } ) ;
563
-
564
- rerender ( < Dialog closable = { { afterClose } } visible = { false } /> ) ;
565
- act ( ( ) => {
566
- jest . runAllTimers ( ) ;
567
- } ) ;
568
- expect ( afterClose ) . toHaveBeenCalledTimes ( 1 ) ;
569
- } ) ;
570
-
571
556
it ( 'should prioritize closable.afterClose when both exist' , ( ) => {
572
557
const afterClose = jest . fn ( ) ;
573
558
const legacyAfterClose = jest . fn ( ) ;
@@ -584,7 +569,7 @@ describe('dialog', () => {
584
569
jest . runAllTimers ( ) ;
585
570
} ) ;
586
571
expect ( afterClose ) . toHaveBeenCalledTimes ( 1 ) ;
587
- expect ( legacyAfterClose ) . toHaveBeenCalledTimes ( 0 ) ;
572
+ expect ( legacyAfterClose ) . toHaveBeenCalledTimes ( 1 ) ;
588
573
} ) ;
589
574
} ) ;
590
575
You can’t perform that action at this time.
0 commit comments