Skip to content

Commit 2891108

Browse files
authored
perf: uninstall classnames, install clsx (#539)
1 parent 1f9af53 commit 2891108

File tree

4 files changed

+16
-33
lines changed

4 files changed

+16
-33
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,15 +46,14 @@
4646
"@rc-component/motion": "^1.1.4",
4747
"@rc-component/portal": "^2.0.0",
4848
"@rc-component/util": "^1.2.1",
49-
"classnames": "^2.2.6"
49+
"clsx": "^2.1.1"
5050
},
5151
"devDependencies": {
5252
"@ant-design/icons": "^5.3.0",
5353
"@rc-component/father-plugin": "^2.0.2",
5454
"@rc-component/np": "^1.0.0",
5555
"@testing-library/jest-dom": "^6.2.0",
5656
"@testing-library/react": "^16.3.0",
57-
"@types/classnames": "^2.2.9",
5857
"@types/jest": "^29.5.11",
5958
"@types/node": "^24.3.0",
6059
"@types/raf": "^3.4.0",

src/DrawerPanel.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import classNames from 'classnames';
1+
import { clsx } from 'clsx';
22
import * as React from 'react';
33
import { RefContext } from './context';
44
import pickAttrs from '@rc-component/util/lib/pickAttrs';
@@ -43,7 +43,7 @@ const DrawerPanel: React.FC<Readonly<DrawerPanelProps>> = props => {
4343

4444
return (
4545
<div
46-
className={classNames(`${prefixCls}-section`, className)}
46+
className={clsx(`${prefixCls}-section`, className)}
4747
role="dialog"
4848
ref={mergedRef}
4949
{...pickAttrs(props, { aria: true })}

src/DrawerPopup.tsx

Lines changed: 11 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import classNames from 'classnames';
1+
import { clsx } from 'clsx';
22
import type { CSSMotionProps } from '@rc-component/motion';
33
import CSSMotion from '@rc-component/motion';
44
import KeyCode from '@rc-component/util/lib/KeyCode';
@@ -248,17 +248,13 @@ const DrawerPopup: React.ForwardRefRenderFunction<
248248
maskRef,
249249
) => (
250250
<div
251-
className={classNames(
251+
className={clsx(
252252
`${prefixCls}-mask`,
253253
motionMaskClassName,
254254
drawerClassNames?.mask,
255255
maskClassName,
256256
)}
257-
style={{
258-
...motionMaskStyle,
259-
...maskStyle,
260-
...styles?.mask,
261-
}}
257+
style={{ ...motionMaskStyle, ...maskStyle, ...styles?.mask }}
262258
onClick={maskClosable && open ? onClose : undefined}
263259
ref={maskRef}
264260
/>
@@ -372,11 +368,8 @@ const DrawerPopup: React.ForwardRefRenderFunction<
372368
id={id}
373369
containerRef={motionRef}
374370
prefixCls={prefixCls}
375-
className={classNames(className, drawerClassNames?.section)}
376-
style={{
377-
...style,
378-
...styles?.section,
379-
}}
371+
className={clsx(className, drawerClassNames?.section)}
372+
style={{ ...style, ...styles?.section }}
380373
{...pickAttrs(props, { aria: true })}
381374
{...eventHandlers}
382375
>
@@ -386,17 +379,13 @@ const DrawerPopup: React.ForwardRefRenderFunction<
386379
return (
387380
<div
388381
ref={wrapperRef}
389-
className={classNames(
382+
className={clsx(
390383
`${prefixCls}-content-wrapper`,
391384
isDragging && `${prefixCls}-content-wrapper-dragging`,
392385
drawerClassNames?.wrapper,
393386
!isDragging && motionClassName,
394387
)}
395-
style={{
396-
...motionStyle,
397-
...wrapperStyle,
398-
...styles?.wrapper,
399-
}}
388+
style={{ ...motionStyle, ...wrapperStyle, ...styles?.wrapper }}
400389
{...pickAttrs(props, { data: true })}
401390
>
402391
{isResizable && <div {...dragElementProps} />}
@@ -419,15 +408,10 @@ const DrawerPopup: React.ForwardRefRenderFunction<
419408
return (
420409
<DrawerContext.Provider value={mergedContext}>
421410
<div
422-
className={classNames(
423-
prefixCls,
424-
`${prefixCls}-${placement}`,
425-
rootClassName,
426-
{
427-
[`${prefixCls}-open`]: open,
428-
[`${prefixCls}-inline`]: inline,
429-
},
430-
)}
411+
className={clsx(prefixCls, `${prefixCls}-${placement}`, rootClassName, {
412+
[`${prefixCls}-open`]: open,
413+
[`${prefixCls}-inline`]: inline,
414+
})}
431415
style={containerStyle}
432416
tabIndex={-1}
433417
ref={panelRef}

src/hooks/useDrag.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import * as React from 'react';
2-
import classNames from 'classnames';
2+
import { clsx } from 'clsx';
33
import type { Placement } from '../Drawer';
44
import { useEvent } from '@rc-component/util';
55

@@ -120,7 +120,7 @@ export default function useDrag(options: UseDragOptions): UseDragReturn {
120120
}
121121
}, [isDragging, handleMouseMove, handleMouseUp]);
122122

123-
const dragElementClassName = classNames(
123+
const dragElementClassName = clsx(
124124
`${prefixCls}-dragger`,
125125
`${prefixCls}-dragger-${direction}`,
126126
{

0 commit comments

Comments
 (0)