fix: modify isControlled logic and test units

Author: QdabuliuQ

src/DrawerPopup.tsx

@@ -284,59 +284,28 @@ const DrawerPopup: React.ForwardRefRenderFunction<
         break;
     }
   }
-  // Track if props changed to detect controlled mode
-  const prevSizeRef = React.useRef<{
-    width?: number | string;
-    height?: number | string;
-  }>({});
-  const isControlledMode = React.useMemo(() => {
-    // Consider controlled if width/height changes between renders (external updates)
-    const currentSize = isHorizontal ? width : height;
-    const prevSize = isHorizontal
-      ? prevSizeRef.current.width
-      : prevSizeRef.current.height;
-
-    const hasExternalUpdate =
-      currentSize !== undefined &&
-      currentSize !== prevSize &&
-      prevSize !== undefined;
-
-    // Update ref for next comparison
-    prevSizeRef.current = { width, height };
-
-    return hasExternalUpdate;
-  }, [width, height, isHorizontal]);
-
-  // Size calculation with controlled mode consideration
+
+  const isControlled = isHorizontal
+    ? width !== undefined
+    : height !== undefined;
+
   if (isHorizontal) {
     let finalWidth: number | string;
-    if (isControlledMode) {
-      // In controlled mode, prioritize external width
-      finalWidth = width !== undefined ? width : defaultWidth;
+    if (isControlled) {
+      finalWidth = width!;
     } else if (currentSize !== undefined) {
-      // In uncontrolled mode, user dragged size takes precedence
       finalWidth = currentSize;
-    } else if (width !== undefined) {
-      // Fallback to provided width
-      finalWidth = width;
     } else {
-      // Final fallback to default
       finalWidth = defaultWidth;
     }
     wrapperStyle.width = parseWidthHeight(finalWidth);
   } else {
     let finalHeight: number | string;
-    if (isControlledMode) {
-      // In controlled mode, prioritize external height
-      finalHeight = height !== undefined ? height : defaultHeight;
+    if (isControlled) {
+      finalHeight = height!;
     } else if (currentSize !== undefined) {
-      // In uncontrolled mode, user dragged size takes precedence
       finalHeight = currentSize;
-    } else if (height !== undefined) {
-      // Fallback to provided height
-      finalHeight = height;
     } else {
-      // Final fallback to default
       finalHeight = defaultHeight;
     }
     wrapperStyle.height = parseWidthHeight(finalHeight);
@@ -388,12 +357,12 @@ const DrawerPopup: React.ForwardRefRenderFunction<
   const handleResize = React.useCallback(
     (size: number) => {
       // In controlled mode, only trigger callback without updating internal state
-      if (!isControlledMode) {
+      if (!isControlled) {
         setCurrentSize(size);
       }
       resizable?.onResize?.(size);
     },
-    [resizable, isControlledMode],
+    [resizable, isControlled],
   );
 
   const handleResizeStart = React.useCallback(() => {

tests/index.spec.tsx

@@ -478,10 +478,7 @@ describe('rc-drawer-menu', () => {
   });
 
   it('should support resizable horizontal', () => {
-    let currentWidth = '200px';
-    const setWidth = (newWidth: number) => {
-      currentWidth = newWidth + 'px';
-    };
+    const setWidth = jest.fn();
     const onResizeStart = jest.fn();
     const onResizeEnd = jest.fn();
 
@@ -499,7 +496,7 @@ describe('rc-drawer-menu', () => {
           }}
           open
           placement="right"
-          width={currentWidth}
+          defaultWidth="200px"
         />
       </div>,
     );
@@ -569,10 +566,7 @@ describe('rc-drawer-menu', () => {
   });
 
   it('should respect minSize and maxSize constraints', () => {
-    let currentWidth = 200;
-    const setWidth = (newWidth: number) => {
-      currentWidth = newWidth;
-    };
+    const setWidth = jest.fn();
 
     const { unmount } = render(
       <div style={{ width: '500px', height: '400px', position: 'relative' }}>
@@ -583,7 +577,7 @@ describe('rc-drawer-menu', () => {
           }}
           open
           placement="left"
-          width={currentWidth}
+          defaultWidth={200}
         />
       </div>,
     );
@@ -637,10 +631,7 @@ describe('rc-drawer-menu', () => {
   });
 
   it('should support resizable vertical', () => {
-    let currentHeight = 200;
-    const setHeight = (newHeight: number) => {
-      currentHeight = newHeight;
-    };
+    const setHeight = jest.fn();
 
     const { unmount } = render(
       <Drawer
@@ -649,7 +640,7 @@ describe('rc-drawer-menu', () => {
         }}
         open
         placement="top"
-        height={currentHeight}
+        defaultHeight={200}
       />,
     );