fix: Should not deep clone non-standard object with setValues

fix ant-design/ant-design#20206

Author: zombieJ

src/utils/valueUtil.ts

@@ -1,6 +1,12 @@
 import setIn from 'lodash/fp/set';
 import get from 'lodash/get';
-import { InternalNamePath, NamePath, Store, StoreValue, EventArgs } from '../interface';
+import {
+  InternalNamePath,
+  NamePath,
+  Store,
+  StoreValue,
+  EventArgs,
+} from '../interface';
 import { toArray } from './typeUtil';
 
 /**
@@ -19,12 +25,19 @@ export function getValue(store: Store, namePath: InternalNamePath) {
   return value;
 }
 
-export function setValue(store: Store, namePath: InternalNamePath, value: StoreValue): Store {
+export function setValue(
+  store: Store,
+  namePath: InternalNamePath,
+  value: StoreValue,
+): Store {
   const newStore = setIn(namePath, value, store);
   return newStore;
 }
 
-export function cloneByNamePathList(store: Store, namePathList: InternalNamePath[]): Store {
+export function cloneByNamePathList(
+  store: Store,
+  namePathList: InternalNamePath[],
+): Store {
   let newStore = {};
   namePathList.forEach(namePath => {
     const value = getValue(store, namePath);
@@ -34,12 +47,21 @@ export function cloneByNamePathList(store: Store, namePathList: InternalNamePath
   return newStore;
 }
 
-export function containsNamePath(namePathList: InternalNamePath[], namePath: InternalNamePath) {
-  return namePathList && namePathList.some(path => matchNamePath(path, namePath));
+export function containsNamePath(
+  namePathList: InternalNamePath[],
+  namePath: InternalNamePath,
+) {
+  return (
+    namePathList && namePathList.some(path => matchNamePath(path, namePath))
+  );
 }
 
 function isObject(obj: StoreValue) {
-  return typeof obj === 'object' && obj !== null;
+  return (
+    typeof obj === 'object' &&
+    obj !== null &&
+    Object.getPrototypeOf(obj) === Object.prototype
+  );
 }
 
 /**
@@ -58,8 +80,10 @@ function internalSetValues<T>(store: T, values: T): T {
     const value = values[key];
 
     // If both are object (but target is not array), we use recursion to set deep value
-    const recursive = isObject(prevValue) && isObject(value) && !Array.isArray(value);
-    newStore[key] = recursive ? internalSetValues(prevValue, value || {}) : value;
+    const recursive = isObject(prevValue) && isObject(value);
+    newStore[key] = recursive
+      ? internalSetValues(prevValue, value || {})
+      : value;
   });
 
   return newStore;
@@ -76,7 +100,11 @@ export function matchNamePath(
   namePath: InternalNamePath,
   changedNamePath: InternalNamePath | null,
 ) {
-  if (!namePath || !changedNamePath || namePath.length !== changedNamePath.length) {
+  if (
+    !namePath ||
+    !changedNamePath ||
+    namePath.length !== changedNamePath.length
+  ) {
     return false;
   }
   return namePath.every((nameUnit, i) => changedNamePath[i] === nameUnit);
@@ -93,7 +121,12 @@ export function isSimilar(source: SimilarObject, target: SimilarObject) {
     return false;
   }
 
-  if (!source || !target || typeof source !== 'object' || typeof target !== 'object') {
+  if (
+    !source ||
+    !target ||
+    typeof source !== 'object' ||
+    typeof target !== 'object'
+  ) {
     return false;
   }
 
@@ -105,14 +138,20 @@ export function isSimilar(source: SimilarObject, target: SimilarObject) {
     const sourceValue = source[key];
     const targetValue = target[key];
 
-    if (typeof sourceValue === 'function' && typeof targetValue === 'function') {
+    if (
+      typeof sourceValue === 'function' &&
+      typeof targetValue === 'function'
+    ) {
       return true;
     }
     return sourceValue === targetValue;
   });
 }
 
-export function defaultGetValueFromEvent(valuePropName: string, ...args: EventArgs) {
+export function defaultGetValueFromEvent(
+  valuePropName: string,
+  ...args: EventArgs
+) {
   const event = args[0];
   if (event && event.target && valuePropName in event.target) {
     return (event.target as HTMLInputElement)[valuePropName];
@@ -133,7 +172,12 @@ export function defaultGetValueFromEvent(valuePropName: string, ...args: EventAr
  */
 export function move<T>(array: T[], moveIndex: number, toIndex: number) {
   const { length } = array;
-  if (moveIndex < 0 || moveIndex >= length || toIndex < 0 || toIndex >= length) {
+  if (
+    moveIndex < 0 ||
+    moveIndex >= length ||
+    toIndex < 0 ||
+    toIndex >= length
+  ) {
     return array;
   }
   const item = array[moveIndex];

tests/utils.test.js

@@ -31,9 +31,17 @@ describe('utils', () => {
       expect(isSimilar(null, {})).toBeFalsy();
     });
 
-    it('setValues', () => {
-      expect(setValues({}, { a: 1 }, { b: 2 })).toEqual({ a: 1, b: 2 });
-      expect(setValues([], [123])).toEqual([123]);
+    describe('setValues', () => {
+      it('basic', () => {
+        expect(setValues({}, { a: 1 }, { b: 2 })).toEqual({ a: 1, b: 2 });
+        expect(setValues([], [123])).toEqual([123]);
+      });
+
+      it('Correct handle class instance', () => {
+        const out = setValues({}, { a: 1, b: { c: new Date() } });
+        expect(out.a).toEqual(1);
+        expect(out.b.c instanceof Date).toBeTruthy();
+      });
     });
   });