Skip to content

Commit 81e3375

Browse files
committed
chore: fix prevValue to be empty string if not defined
1 parent 296327d commit 81e3375

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

src/InputNumber.tsx

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -206,7 +206,7 @@ const InternalInputNumber = React.forwardRef(
206206
const numStr = String(num);
207207

208208
if (parser) {
209-
return parser(numStr, { prevValue: String(prevValueRef.current) });
209+
return parser(numStr, { prevValue: String(prevValueRef.current ?? '') });
210210
}
211211

212212
let parsedStr = numStr;
@@ -227,7 +227,7 @@ const InternalInputNumber = React.forwardRef(
227227
return formatter(number, {
228228
userTyping,
229229
input: String(inputValueRef.current),
230-
prevValue: String(prevValueRef.current),
230+
prevValue: String(prevValueRef.current ?? ''),
231231
});
232232
}
233233

@@ -389,10 +389,9 @@ const InternalInputNumber = React.forwardRef(
389389

390390
// >>> Collect input value
391391
const collectInputValue = (inputStr: string) => {
392-
393392
// validate string
394-
if(validator){
395-
if(!validator(inputStr)) return;
393+
if (validator) {
394+
if (!validator(inputStr)) return;
396395
}
397396

398397
recordCursor();

tests/formatter.test.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ describe('InputNumber.Formatter', () => {
163163

164164
fireEvent.change(container.querySelector('input'), { target: { value: '1' } });
165165
expect(formatter).toHaveBeenCalledTimes(1);
166-
expect(formatter).toHaveBeenCalledWith('1', { userTyping: true, input: '1' });
166+
expect(formatter).toHaveBeenCalledWith('1', { userTyping: true, input: '1', prevValue: '' });
167167
});
168168

169169
describe('dynamic formatter', () => {

0 commit comments

Comments
 (0)