From 784a5003c3fabd510ac15178ffa2a887af4ae17f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E9=B9=A4=E4=BB=99?= Date: Mon, 3 Nov 2025 18:00:59 +0800 Subject: [PATCH 1/2] fix: type to mode --- assets/index.less | 8 +++--- docs/demo/spinner.tsx | 6 ++--- src/InputNumber.tsx | 28 ++++++++------------- tests/__snapshots__/baseInput.test.tsx.snap | 6 ++--- tests/props.test.tsx | 4 +-- 5 files changed, 22 insertions(+), 30 deletions(-) diff --git a/assets/index.less b/assets/index.less index e3e559e5..ed5ab089 100644 --- a/assets/index.less +++ b/assets/index.less @@ -134,22 +134,22 @@ } } - &-type-spinner { + &-mode-spinner { display: inline-flex; align-items: center; } - &-type-spinner &-handler { + &-mode-spinner &-handler { flex: 0 0 20px; line-height: 26px; height: 100%; } - &-type-spinner &-handler-up { + &-mode-spinner &-handler-up { border-bottom: 0; border-left: 1px solid #d9d9d9; } - &-type-spinner &-handler-down { + &-mode-spinner &-handler-down { border-top: 0; border-right: 1px solid #d9d9d9; } diff --git a/docs/demo/spinner.tsx b/docs/demo/spinner.tsx index 085bc0b3..44e77bd7 100644 --- a/docs/demo/spinner.tsx +++ b/docs/demo/spinner.tsx @@ -20,7 +20,7 @@ export default () => {

Controlled

{

Uncontrolled

{

!changeOnBlur

/** value will show as string */ stringMode?: boolean; - type?: 'input' | 'spinner'; + mode?: 'input' | 'spinner'; defaultValue?: T; value?: T | null; @@ -122,7 +122,7 @@ type InternalInputNumberProps = Omit & { const InternalInputNumber = React.forwardRef( (props: InternalInputNumberProps, ref: React.Ref) => { const { - type, + mode, prefixCls, className, style, @@ -601,21 +601,13 @@ const InternalInputNumber = React.forwardRef( }; const upNode = ( - + {upHandler} ); const downNode = ( - + {downHandler} ); @@ -642,7 +634,7 @@ const InternalInputNumber = React.forwardRef( onCompositionEnd={onCompositionEnd} onBeforeInput={onBeforeInput} > - {type === 'input' && controls && ( + {mode === 'input' && controls && (
)} - {type === 'spinner' && controls && downNode} + {mode === 'spinner' && controls && downNode}
- {type === 'spinner' && controls && upNode} + {mode === 'spinner' && controls && upNode}
); }, @@ -680,7 +672,7 @@ const InternalInputNumber = React.forwardRef( const InputNumber = React.forwardRef((props, ref) => { const { - type = 'input', + mode = 'input', disabled, style, prefixCls = 'rc-input-number', @@ -715,7 +707,7 @@ const InputNumber = React.forwardRef((props, r return ( ((props, r ref={holderRef} >

{ describe('type props', () => { it('render spinner type', () => { - const { container } = render(); - expect(container.querySelector('.rc-input-number')).toHaveClass('rc-input-number-type-spinner'); + const { container } = render(); + expect(container.querySelector('.rc-input-number')).toHaveClass('rc-input-number-mode-spinner'); }); }); From 737498d31bc61125a7cfc1bd7d19b60f46d8c6cd Mon Sep 17 00:00:00 2001 From: Guo Yunhe Date: Mon, 3 Nov 2025 22:22:37 +0800 Subject: [PATCH 2/2] Update tests/props.test.tsx Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> --- tests/props.test.tsx | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/props.test.tsx b/tests/props.test.tsx index 8001c20e..69b7b281 100644 --- a/tests/props.test.tsx +++ b/tests/props.test.tsx @@ -407,8 +407,8 @@ describe('InputNumber.Props', () => { }); }); - describe('type props', () => { - it('render spinner type', () => { + describe('mode props', () => { + it('render spinner mode', () => { const { container } = render(); expect(container.querySelector('.rc-input-number')).toHaveClass('rc-input-number-mode-spinner'); });