Skip to content

Commit 27271d6

Browse files
authored
feat: remove shallowequal (#572)
1 parent 7fe378c commit 27271d6

File tree

3 files changed

+5
-6
lines changed

3 files changed

+5
-6
lines changed

package.json

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -48,8 +48,7 @@
4848
"rc-motion": "^2.4.3",
4949
"rc-overflow": "^1.2.8",
5050
"rc-trigger": "^5.1.2",
51-
"rc-util": "^5.12.0",
52-
"shallowequal": "^1.1.0"
51+
"rc-util": "^5.27.0"
5352
},
5453
"devDependencies": {
5554
"@testing-library/jest-dom": "^5.16.4",

src/Menu.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import warning from 'rc-util/lib/warning';
66
import * as React from 'react';
77
import { useImperativeHandle } from 'react';
88
import { flushSync } from 'react-dom';
9-
import shallowEqual from 'shallowequal';
9+
import isEqual from 'rc-util/lib/isEqual';
1010
import { getMenuId, IdContext } from './context/IdContext';
1111
import MenuContextProvider from './context/MenuContext';
1212
import { PathRegisterContext, PathUserContext } from './context/PathContext';
@@ -474,7 +474,7 @@ const Menu = React.forwardRef<MenuRef, MenuProps>((props, ref) => {
474474
newOpenKeys = newOpenKeys.filter(k => !subPathKeys.has(k));
475475
}
476476

477-
if (!shallowEqual(mergedOpenKeys, newOpenKeys)) {
477+
if (!isEqual(mergedOpenKeys, newOpenKeys, true)) {
478478
triggerOpenKeys(newOpenKeys, true);
479479
}
480480
});

src/context/MenuContext.tsx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import * as React from 'react';
22
import type { CSSMotionProps } from 'rc-motion';
33
import useMemo from 'rc-util/lib/hooks/useMemo';
4-
import shallowEqual from 'shallowequal';
4+
import isEqual from 'rc-util/lib/isEqual';
55
import type {
66
BuiltinPlacements,
77
MenuClickEventHandler,
@@ -90,7 +90,7 @@ export default function InheritableContextProvider({
9090
() => mergeProps(context, restProps),
9191
[context, restProps],
9292
(prev, next) =>
93-
!locked && (prev[0] !== next[0] || !shallowEqual(prev[1], next[1])),
93+
!locked && (prev[0] !== next[0] || !isEqual(prev[1], next[1], true)),
9494
);
9595

9696
return (

0 commit comments

Comments
 (0)