Skip to content

Commit 394d3ee

Browse files
authored
types: add export of menuItemProps and subMenuProps; (#329)
chore(menu-item): optimize props;
1 parent 1ccf4c8 commit 394d3ee

File tree

2 files changed

+16
-4
lines changed

2 files changed

+16
-4
lines changed

src/MenuItem.tsx

Lines changed: 12 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import React from 'react';
22
import KeyCode from 'rc-util/lib/KeyCode';
33
import classNames from 'classnames';
4+
import omit from 'omit.js';
45
import { connect } from 'mini-store';
56
import { noop, menuAllProps } from './util';
67
import {
@@ -16,7 +17,11 @@ import {
1617

1718
/* eslint react/no-is-mounted:0 */
1819

19-
export interface MenuItemProps {
20+
export interface MenuItemProps
21+
extends Omit<
22+
React.HTMLAttributes<HTMLLIElement>,
23+
'onClick' | 'onMouseEnter' | 'onMouseLeave' | 'onSelect'
24+
> {
2025
/** @deprecated No place to use this. Should remove */
2126
attribute?: Record<string, string>;
2227
rootPrefixCls?: string;
@@ -225,7 +230,12 @@ export class MenuItem extends React.Component<MenuItemProps> {
225230
}
226231
return (
227232
<li
228-
{...(props as any)}
233+
{...omit(props, [
234+
'onClick',
235+
'onMouseEnter',
236+
'onMouseLeave',
237+
'onSelect',
238+
])}
229239
{...attrs}
230240
{...mouseEvent}
231241
style={style}

src/index.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Menu, { MenuProps } from './Menu';
2-
import SubMenu from './SubMenu';
3-
import MenuItem from './MenuItem';
2+
import SubMenu, { SubMenuProps } from './SubMenu';
3+
import MenuItem, { MenuItemProps } from './MenuItem';
44
import MenuItemGroup, { MenuItemGroupProps } from './MenuItemGroup';
55
import Divider from './Divider';
66

@@ -12,6 +12,8 @@ export {
1212
MenuItemGroup as ItemGroup,
1313
Divider,
1414
MenuProps,
15+
SubMenuProps,
16+
MenuItemProps,
1517
MenuItemGroupProps,
1618
};
1719

0 commit comments

Comments
 (0)