Skip to content

Commit 5e607ff

Browse files
authored
performance: cache children to improve performance (#426)
1 parent 700ce5c commit 5e607ff

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

src/Menu.tsx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -226,11 +226,11 @@ const Menu = React.forwardRef<MenuRef, MenuProps>((props, ref) => {
226226
...restProps
227227
} = props as LegacyMenuProps;
228228

229-
const childList: React.ReactElement[] = parseItems(
230-
children,
231-
items,
232-
EMPTY_LIST,
229+
const childList: React.ReactElement[] = React.useMemo(
230+
() => parseItems(children, items, EMPTY_LIST),
231+
[children, items],
233232
);
233+
234234
const [mounted, setMounted] = React.useState(false);
235235

236236
const containerRef = React.useRef<HTMLUListElement>();

0 commit comments

Comments
 (0)