Skip to content

Commit a0e77da

Browse files
committed
fix: React key warning
1 parent 758cce2 commit a0e77da

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

examples/fragment.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,12 +8,10 @@ export default () => (
88
<MenuItem key="1-1">0-1</MenuItem>
99
<MenuItem key="1-2">0-2</MenuItem>
1010
</SubMenu>
11-
<MenuItem key="2">
12-
Menu Item
13-
</MenuItem>
11+
<MenuItem key="2">Menu Item</MenuItem>
1412
<MenuItem key="3">outer</MenuItem>
1513
<>
16-
<SubMenu title="sub menu" key="4">
14+
<SubMenu key="4" title="sub menu">
1715
<MenuItem key="4-1">inner inner</MenuItem>
1816
<Divider />
1917
<SubMenu key="4-2" title="sub menu">

src/SubPopupMenu.tsx

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,10 @@ export class SubPopupMenu extends React.Component<SubPopupMenuProps> {
393393
if (props.mode === 'inline' || isMobileDevice()) {
394394
newChildProps.triggerSubMenuAction = 'click';
395395
}
396-
return React.cloneElement(child, newChildProps);
396+
return React.cloneElement(child, {
397+
...newChildProps,
398+
key: key || i,
399+
});
397400
};
398401

399402
renderMenuItem = (

0 commit comments

Comments
 (0)