Skip to content

Commit f4d7190

Browse files
afc163zombieJ
authored andcommitted
🐛 Fix active item cannot be scrolled (#284)
close ant-design/ant-design#18939
1 parent 353039b commit f4d7190

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

src/MenuItem.jsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@ export class MenuItem extends React.Component {
5353
const { active, parentMenu, eventKey } = this.props;
5454
// 在 parentMenu 上层保存滚动状态,避免重复的 MenuItem key 导致滚动跳动
5555
// https://github.com/ant-design/ant-design/issues/16181
56-
if (!prevProps.active && active && (!parentMenu && !parentMenu[`scrolled-${eventKey}`])) {
56+
if (!prevProps.active && active && (!parentMenu || !parentMenu[`scrolled-${eventKey}`])) {
5757
if (this.node) {
5858
scrollIntoView(this.node, ReactDOM.findDOMNode(parentMenu), {
5959
onlyScrollIfNeeded: true,

0 commit comments

Comments
 (0)