Skip to content

Commit f9563a0

Browse files
committed
refactor MenuItem componentDidUpdate
1 parent 72242cf commit f9563a0

File tree

1 file changed

+8
-2
lines changed

1 file changed

+8
-2
lines changed

src/MenuItem.jsx

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -50,8 +50,9 @@ export class MenuItem extends React.Component {
5050
}
5151

5252
componentDidUpdate() {
53-
if (this.props.active) {
54-
scrollIntoView(ReactDOM.findDOMNode(this), ReactDOM.findDOMNode(this.props.parentMenu), {
53+
const { active, parentMenu } = this.props;
54+
if (active && this.node) {
55+
scrollIntoView(this.node, ReactDOM.findDOMNode(parentMenu), {
5556
onlyScrollIfNeeded: true,
5657
});
5758
}
@@ -133,6 +134,10 @@ export class MenuItem extends React.Component {
133134
return `${this.getPrefixCls()}-disabled`;
134135
}
135136

137+
saveNode = (node) => {
138+
this.node = node;
139+
}
140+
136141
callRef() {
137142
if (this.props.manualRef) {
138143
this.props.manualRef(this);
@@ -193,6 +198,7 @@ export class MenuItem extends React.Component {
193198
{...attrs}
194199
{...mouseEvent}
195200
style={style}
201+
ref={this.saveNode}
196202
>
197203
{props.children}
198204
{icon}

0 commit comments

Comments
 (0)