Skip to content

Commit 6a07ec1

Browse files
authored
chore: Overflow will adjust position (#11)
1 parent f48322b commit 6a07ec1

File tree

2 files changed

+11
-7
lines changed

2 files changed

+11
-7
lines changed

src/Item.tsx

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,10 @@
11
import * as React from 'react';
22
import classNames from 'classnames';
33
import ResizeObserver from 'rc-resize-observer';
4-
import { ComponentType } from './Overflow';
4+
import type { ComponentType } from './Overflow';
5+
6+
// Use shared variable to save bundle size
7+
const UNDEFINED = undefined;
58

69
export interface ItemProps<ItemType> extends React.HTMLAttributes<any> {
710
prefixCls: string;
@@ -56,16 +59,17 @@ function InternalItem<ItemType>(
5659

5760
// ================================ Render ================================
5861
const childNode =
59-
renderItem && item !== undefined ? renderItem(item) : children;
62+
renderItem && item !== UNDEFINED ? renderItem(item) : children;
6063

6164
let overflowStyle: React.CSSProperties | undefined;
6265
if (!invalidate) {
6366
overflowStyle = {
6467
opacity: mergedHidden ? 0 : 1,
65-
height: mergedHidden ? 0 : undefined,
66-
overflowY: mergedHidden ? 'hidden' : undefined,
67-
order: responsive ? order : undefined,
68-
pointerEvents: mergedHidden ? 'none' : undefined,
68+
height: mergedHidden ? 0 : UNDEFINED,
69+
overflowY: mergedHidden ? 'hidden' : UNDEFINED,
70+
order: responsive ? order : UNDEFINED,
71+
pointerEvents: mergedHidden ? 'none' : UNDEFINED,
72+
position: mergedHidden ? 'absolute' : UNDEFINED,
6973
};
7074
}
7175

tests/__snapshots__/ssr.spec.tsx.snap

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ exports[`Overflow.SSR basic 1`] = `
1919
<div
2020
aria-hidden="true"
2121
class="rc-overflow-item rc-overflow-item-rest"
22-
style="opacity:0;height:0;overflow-y:hidden;order:9007199254740991;pointer-events:none"
22+
style="opacity:0;height:0;overflow-y:hidden;order:9007199254740991;pointer-events:none;position:absolute"
2323
>
2424
+ 0 ...
2525
</div>

0 commit comments

Comments
 (0)