test: Fill range test case

Author: zombieJ

src/Picker.tsx

@@ -14,6 +14,7 @@
 import * as React from 'react';
 import classNames from 'classnames';
 import { AlignType } from 'rc-trigger/lib/interface';
+import { warning } from 'rc-util/lib/warning';
 import PickerPanel, {
   PickerPanelBaseProps,
   PickerPanelDateProps,
@@ -230,7 +231,16 @@ function InnerPicker<DateType>(props: PickerProps<DateType>) {
       // Let popup panel handle keyboard
       return operationRef.current.onKeyDown(e);
     }
-    return false;
+
+    /* istanbul ignore next */
+    /* eslint-disable no-lone-blocks */
+    {
+      warning(
+        false,
+        'Picker not correct forward KeyDown operation. Please help to fire issue about this.',
+      );
+      return false;
+    }
   };
 
   // ============================= Text ==============================

src/RangePicker.tsx

@@ -1,5 +1,6 @@
 import * as React from 'react';
 import classNames from 'classnames';
+import warning from 'rc-util/lib/warning';
 import {
   DisabledTimes,
   PanelMode,
@@ -69,11 +70,6 @@ function canValueTrigger<DateType>(
     return true;
   }
 
-  // If another one is disabled, this can be trigger
-  if (disabledList[(index + 1) % 2]) {
-    return true;
-  }
-
   return false;
 }
 
@@ -620,6 +616,21 @@ function InnerRangePicker<DateType>(props: RangePickerProps<DateType>) {
     setSelectedValue(mergedValue);
   }, [mergedValue]);
 
+  // ============================ Warning ============================
+  if (process.env.NODE_ENV !== 'production') {
+    if (
+      value &&
+      Array.isArray(disabled) &&
+      ((getValue(disabled, 0) && !getValue(value, 0)) ||
+        (getValue(disabled, 1) && !getValue(value, 1)))
+    ) {
+      warning(
+        false,
+        '`disabled` should not set with empty `value`. You should set `allowEmpty` or `value` instead.',
+      );
+    }
+  }
+
   // ============================ Private ============================
   if (pickerRef) {
     pickerRef.current = {

tests/range.spec.tsx

@@ -250,19 +250,16 @@ describe('Picker.Range', () => {
       );
     });
 
-    it('allowEmpty with disabled', () => {
-      const onChange = jest.fn();
-      const wrapper = mount(
-        <MomentRangePicker
-          disabled={[false, true]}
-          allowEmpty={[false, true]}
-          onChange={onChange}
-        />,
+    it('null value with disabled', () => {
+      const errSpy = jest.spyOn(console, 'error').mockImplementation(() => {});
+      mount(
+        <MomentRangePicker disabled={[false, true]} value={[null, null]} />,
       );
 
-      wrapper.openPicker();
-      wrapper.selectCell(11);
-      expect(onChange.mock.calls[0][1]).toEqual(['1990-09-11', '']);
+      expect(errSpy).toHaveBeenCalledWith(
+        'Warning: `disabled` should not set with empty `value`. You should set `allowEmpty` or `value` instead.',
+      );
+      errSpy.mockReset();
     });
   });
 
@@ -569,6 +566,7 @@ describe('Picker.Range', () => {
 
     // Select to active next
     wrapper.selectCell(11);
+    jest.runAllTimers();
     expect(
       wrapper
         .find('.rc-picker-input')
@@ -619,4 +617,17 @@ describe('Picker.Range', () => {
       });
     });
   });
+
+  it('should close when user focus out', () => {
+    const wrapper = mount(<MomentRangePicker />);
+    wrapper.openPicker();
+    wrapper.selectCell(11);
+    expect(wrapper.isOpen()).toBeTruthy();
+
+    wrapper
+      .find('input')
+      .last()
+      .simulate('blur');
+    expect(wrapper.isOpen()).toBeFalsy();
+  });
 });