Skip to content

Commit 8d422b6

Browse files
authored
fix: Disabled should not click to open (#51)
* test case * not open
1 parent fbaf05b commit 8d422b6

File tree

2 files changed

+13
-0
lines changed

2 files changed

+13
-0
lines changed

src/Picker.tsx

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -240,6 +240,10 @@ function InnerPicker<DateType>(props: PickerProps<DateType>) {
240240
};
241241

242242
const triggerOpen = (newOpen: boolean, preventChangeEvent: boolean = false) => {
243+
if (disabled && newOpen) {
244+
return;
245+
}
246+
243247
triggerInnerOpen(newOpen);
244248
if (!newOpen && !preventChangeEvent) {
245249
triggerChange(selectedValue);

tests/picker.spec.tsx

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -546,6 +546,15 @@ describe('Picker.Basic', () => {
546546
expect(onMouseUp).toHaveBeenCalled();
547547
});
548548

549+
it('not open when disabled', () => {
550+
const wrapper = mount(<MomentPicker disabled />);
551+
wrapper.find('.rc-picker').simulate('mouseUp');
552+
expect(wrapper.isOpen()).toBeFalsy();
553+
554+
wrapper.setProps({ disabled: false });
555+
expect(wrapper.isOpen()).toBeFalsy();
556+
});
557+
549558
it('defaultOpenValue in timePicker', () => {
550559
resetWarned();
551560
const onChange = jest.fn();

0 commit comments

Comments
 (0)