Skip to content

Commit f1ab1e0

Browse files
authored
chore: add role to clear button (#250)
* chore: add role to clear button * chore: update snapshot
1 parent 8bc4cce commit f1ab1e0

File tree

2 files changed

+10
-6
lines changed

2 files changed

+10
-6
lines changed

src/Picker.tsx

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -98,9 +98,11 @@ type OmitPanelProps<Props> = Omit<
9898
'onChange' | 'hideHeader' | 'pickerValue' | 'onPickerValueChange'
9999
>;
100100

101-
export type PickerBaseProps<DateType> = {} & PickerSharedProps<DateType> & OmitPanelProps<PickerPanelBaseProps<DateType>>;
101+
export type PickerBaseProps<DateType> = {} & PickerSharedProps<DateType> &
102+
OmitPanelProps<PickerPanelBaseProps<DateType>>;
102103

103-
export type PickerDateProps<DateType> = {} & PickerSharedProps<DateType> & OmitPanelProps<PickerPanelDateProps<DateType>>;
104+
export type PickerDateProps<DateType> = {} & PickerSharedProps<DateType> &
105+
OmitPanelProps<PickerPanelDateProps<DateType>>;
104106

105107
export type PickerTimeProps<DateType> = {
106108
picker: 'time';
@@ -109,7 +111,8 @@ export type PickerTimeProps<DateType> = {
109111
* since `defaultOpenValue` will confuse user of current value status
110112
*/
111113
defaultOpenValue?: DateType;
112-
} & PickerSharedProps<DateType> & Omit<OmitPanelProps<PickerPanelTimeProps<DateType>>, 'format'>;
114+
} & PickerSharedProps<DateType> &
115+
Omit<OmitPanelProps<PickerPanelTimeProps<DateType>>, 'format'>;
113116

114117
export type PickerProps<DateType> =
115118
| PickerBaseProps<DateType>
@@ -194,9 +197,8 @@ function InnerPicker<DateType>(props: PickerProps<DateType>) {
194197
const [selectedValue, setSelectedValue] = React.useState<DateType | null>(mergedValue);
195198

196199
// Operation ref
197-
const operationRef: React.MutableRefObject<ContextOperationRefProps | null> = React.useRef<ContextOperationRefProps>(
198-
null,
199-
);
200+
const operationRef: React.MutableRefObject<ContextOperationRefProps | null> =
201+
React.useRef<ContextOperationRefProps>(null);
200202

201203
// Open
202204
const [mergedOpen, triggerInnerOpen] = useMergedState(false, {
@@ -433,6 +435,7 @@ function InnerPicker<DateType>(props: PickerProps<DateType>) {
433435
triggerOpen(false);
434436
}}
435437
className={`${prefixCls}-clear`}
438+
role="button"
436439
>
437440
{clearIcon || <span className={`${prefixCls}-clear-btn`} />}
438441
</span>

tests/__snapshots__/picker.spec.tsx.snap

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,7 @@ exports[`Picker.Basic icon 1`] = `
2020
</span>
2121
<span
2222
class="rc-picker-clear"
23+
role="button"
2324
>
2425
<span
2526
class="suffix-icon"

0 commit comments

Comments
 (0)