Skip to content

fix(a11y): fix table header is empty and add localization support #904

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 7, 2025
Merged

fix(a11y): fix table header is empty and add localization support #904

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dcf600e
feat: improve a11y when table header is empty
aojunhao123 Jan 24, 2025
76da25a
feat: Add 'week' localization support across multiple locales
aojunhao123 Feb 6, 2025
7660147
fix: Update Turkmen locale 'week' translation
aojunhao123 Feb 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion src/PickerPanel/DatePanel/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,13 @@ export default function DatePanel<DateType extends object = any>(props: DatePane
: []);

if (prefixColumn) {
headerCells.push(<th key="empty" aria-label="empty cell" />);
headerCells.push(
<th key="empty">
<span style={{ width: 0, height: 0, position: 'absolute', overflow: 'hidden', opacity: 0 }}>
Week
</span>
</th>,
);
}
for (let i = 0; i < WEEK_DAY_COUNT; i += 1) {
headerCells.push(<th key={i}>{weekDaysLocale[(i + weekFirstDay) % WEEK_DAY_COUNT]}</th>);
Expand Down
20 changes: 14 additions & 6 deletions tests/__snapshots__/panel.spec.tsx.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3395,9 +3395,13 @@ exports[`Picker.Panel append cell with cellRender in week 1`] = `
>
<thead>
<tr>
<th
aria-label="empty cell"
/>
<th>
<span
style="width: 0px; height: 0px; position: absolute; overflow: hidden; opacity: 0;"
>
Week
</span>
</th>
<th>
Su
</th>
Expand Down Expand Up @@ -6954,9 +6958,13 @@ exports[`Picker.Panel override cell with cellRender in week 1`] = `
>
<thead>
<tr>
<th
aria-label="empty cell"
/>
<th>
<span
style="width: 0px; height: 0px; position: absolute; overflow: hidden; opacity: 0;"
>
Week
</span>
</th>
<th>
Su
</th>
Expand Down