Skip to content

Commit 46fdd36

Browse files
committed
Revert "feat: support suffix (#711)"
This reverts commit 901bd49.
1 parent 452d917 commit 46fdd36

File tree

8 files changed

+2
-54
lines changed

8 files changed

+2
-54
lines changed

README.md

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -128,7 +128,6 @@ export default () => (
128128
| loading | show loading icon in arrow | Boolean | false |
129129
| virtual | Disable virtual scroll | Boolean | true |
130130
| direction | direction of dropdown | 'ltr' \| 'rtl' | 'ltr' |
131-
| suffix | suffix of select input | ReactNode | - |
132131

133132
### Methods
134133

assets/index.less

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -253,18 +253,6 @@
253253
color: #999;
254254
}
255255
}
256-
257-
&-has-suffix {
258-
.@{select-prefix}-arrow {
259-
right: 16px;
260-
}
261-
}
262-
263-
&-suffix {
264-
position: absolute;
265-
right: 4px;
266-
top: 0;
267-
}
268256
}
269257

270258
.@{select-prefix}-selection__choice-zoom {

docs/demo/suffix.md

Lines changed: 0 additions & 2 deletions
This file was deleted.

docs/examples/suffix.tsx

Lines changed: 0 additions & 15 deletions
This file was deleted.

src/BaseSelect.tsx

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,6 @@ import useDelayReset from './hooks/useDelayReset';
1616
import TransBtn from './TransBtn';
1717
import useLock from './hooks/useLock';
1818
import { BaseSelectContext } from './hooks/useBaseProps';
19-
import type { ReactNode } from 'react';
2019

2120
const DEFAULT_OMIT_PROPS = [
2221
'value',
@@ -170,7 +169,6 @@ export interface BaseSelectProps extends BaseSelectPrivateProps, React.AriaAttri
170169
clearIcon?: RenderNode;
171170
/** Selector remove icon */
172171
removeIcon?: RenderNode;
173-
suffix?: ReactNode;
174172

175173
// >>> Dropdown
176174
animation?: string;
@@ -275,8 +273,6 @@ const BaseSelect = React.forwardRef((props: BaseSelectProps, ref: React.Ref<Base
275273
onKeyDown,
276274
onMouseDown,
277275

278-
suffix,
279-
280276
// Rest Props
281277
...restProps
282278
} = props;
@@ -722,7 +718,6 @@ const BaseSelect = React.forwardRef((props: BaseSelectProps, ref: React.Ref<Base
722718
[`${prefixCls}-open`]: mergedOpen,
723719
[`${prefixCls}-customize-input`]: customizeInputElement,
724720
[`${prefixCls}-show-search`]: mergedShowSearch,
725-
[`${prefixCls}-has-suffix`]: suffix,
726721
});
727722

728723
// >>> Selector
@@ -820,7 +815,6 @@ const BaseSelect = React.forwardRef((props: BaseSelectProps, ref: React.Ref<Base
820815

821816
{arrowNode}
822817
{clearNode}
823-
{suffix && <span className={`${prefixCls}-suffix`}>{suffix}</span>}
824818
</div>
825819
);
826820
}

src/Select.tsx

Lines changed: 2 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,12 @@
3232
import * as React from 'react';
3333
import warning from 'rc-util/lib/warning';
3434
import useMergedState from 'rc-util/lib/hooks/useMergedState';
35-
import type {
36-
BaseSelectProps,
37-
BaseSelectPropsWithoutPrivate,
38-
BaseSelectRef,
39-
DisplayValueType,
40-
RenderNode,
41-
} from './BaseSelect';
4235
import BaseSelect, { isMultiple } from './BaseSelect';
36+
import type { DisplayValueType, RenderNode } from './BaseSelect';
4337
import OptionList from './OptionList';
4438
import Option from './Option';
4539
import OptGroup from './OptGroup';
40+
import type { BaseSelectRef, BaseSelectPropsWithoutPrivate, BaseSelectProps } from './BaseSelect';
4641
import useOptions from './hooks/useOptions';
4742
import SelectContext from './SelectContext';
4843
import useId from './hooks/useId';

src/Selector/index.tsx

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,6 @@
99
*/
1010

1111
import * as React from 'react';
12-
import type { ReactNode } from 'react';
1312
import { useRef } from 'react';
1413
import KeyCode from 'rc-util/lib/KeyCode';
1514
import type { ScrollTo } from 'rc-virtual-list/lib/List';
@@ -94,8 +93,6 @@ export interface SelectorProps {
9493
* This may be removed after React provides replacement of `findDOMNode`
9594
*/
9695
domRef: React.Ref<HTMLDivElement>;
97-
98-
suffix?: ReactNode;
9996
}
10097

10198
const Selector: React.RefForwardingComponent<RefSelectorProps, SelectorProps> = (props, ref) => {

tests/Select.test.tsx

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1789,12 +1789,4 @@ describe('Select.Basic', () => {
17891789
.visibility,
17901790
).toBe('hidden');
17911791
});
1792-
1793-
it('should support suffix', () => {
1794-
const wrapper = mount(<Select suffix=":)" />);
1795-
1796-
expect(wrapper.find('.rc-select-has-suffix')).toBeTruthy();
1797-
expect(wrapper.find('.rc-select-suffix')).toBeTruthy();
1798-
expect(wrapper.find('.rc-select-suffix').text()).toEqual(':)');
1799-
});
18001792
});

0 commit comments

Comments
 (0)