feat: Prevent long press of enter (#1053)

* feat: Prevent long press of enter

* feat: lint

* feat: test

* feat: test

* feat: 优化代码

* feat: test

* feat: 优化代码

* feat: 判断方式

* feat: 删除判断

* feat: 优化代码

* feat: reviewg

* feat: review

Author: crazyair

src/BaseSelect/index.tsx

@@ -3,7 +3,6 @@ import classNames from 'classnames';
 import useLayoutEffect from 'rc-util/lib/hooks/useLayoutEffect';
 import useMergedState from 'rc-util/lib/hooks/useMergedState';
 import isMobile from 'rc-util/lib/isMobile';
-import KeyCode from 'rc-util/lib/KeyCode';
 import { useComposeRef } from 'rc-util/lib/ref';
 import type { ScrollConfig, ScrollTo } from 'rc-virtual-list/lib/List';
 import * as React from 'react';
@@ -480,13 +479,16 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
    * - false: Search text is not empty when first time backspace down
    */
   const [getClearLock, setClearLock] = useLock();
+  const keyLockRef = React.useRef(false);
 
   // KeyDown
   const onInternalKeyDown: React.KeyboardEventHandler<HTMLDivElement> = (event, ...rest) => {
     const clearLock = getClearLock();
-    const { which } = event;
+    const { key } = event;
 
-    if (which === KeyCode.ENTER) {
+    const isEnterKey = key === 'Enter';
+
+    if (isEnterKey) {
       // Do not submit form when type in the input
       if (mode !== 'combobox') {
         event.preventDefault();
@@ -502,7 +504,7 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
 
     // Remove value by `backspace`
     if (
-      which === KeyCode.BACKSPACE &&
+      key === 'Backspace' &&
       !clearLock &&
       multiple &&
       !mergedSearchValue &&
@@ -529,10 +531,14 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
       }
     }
 
-    if (mergedOpen) {
+    if (mergedOpen && (!isEnterKey || !keyLockRef.current)) {
       listRef.current?.onKeyDown(event, ...rest);
     }
 
+    if (isEnterKey) {
+      keyLockRef.current = true;
+    }
+
     onKeyDown?.(event, ...rest);
   };
 
@@ -541,7 +547,9 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
     if (mergedOpen) {
       listRef.current?.onKeyUp(event, ...rest);
     }
-
+    if (event.key === 'Enter') {
+      keyLockRef.current = false;
+    }
     onKeyUp?.(event, ...rest);
   };
 

tests/Multiple.test.tsx

@@ -16,6 +16,7 @@ import {
   findSelection,
   removeSelection,
   keyDown,
+  keyUp,
 } from './utils/common';
 import allowClearTest from './shared/allowClearTest';
 import { fireEvent, render } from '@testing-library/react';
@@ -294,6 +295,25 @@ describe('Select.Multiple', () => {
     expect(onChange).toHaveBeenCalledWith([2], expect.anything());
   });
 
+  it('should prevent long press of enter', () => {
+    const onChange = jest.fn();
+    const { container } = render(
+      <Select mode="multiple" onChange={onChange}>
+        <Option value={1}>1</Option>
+        <Option value={2}>2</Option>
+      </Select>,
+    );
+
+    toggleOpen(container);
+    fireEvent.mouseMove(container.querySelectorAll('.rc-select-item-option')[1]);
+
+    keyDown(container.querySelector('input'), KeyCode.ENTER);
+    keyDown(container.querySelector('input'), KeyCode.ENTER);
+    keyUp(container.querySelector('input'), KeyCode.ENTER);
+    expectOpen(container);
+    expect(onChange).toHaveBeenCalledTimes(1);
+  });
+
   it('enter twice to cancel the selection', () => {
     const onChange = jest.fn();
     const { container } = render(
@@ -306,7 +326,7 @@ describe('Select.Multiple', () => {
     toggleOpen(container);
     fireEvent.mouseMove(container.querySelectorAll('.rc-select-item-option')[0]);
     keyDown(container.querySelector('input'), KeyCode.ENTER);
-
+    keyUp(container.querySelector('input'), KeyCode.ENTER);
     fireEvent.mouseMove(container.querySelectorAll('.rc-select-item-option')[0]);
     keyDown(container.querySelector('input'), KeyCode.ENTER);
 

tests/Select.test.tsx

@@ -25,6 +25,7 @@ import {
   findSelection,
   injectRunAllTimers,
   keyDown,
+  keyUp,
   selectItem,
   toggleOpen,
 } from './utils/common';
@@ -1469,6 +1470,7 @@ describe('Select.Basic', () => {
     for (let i = 0; i < 10; i += 1) {
       onSelect.mockReset();
       keyDown(container.querySelector('input'), KeyCode.ENTER);
+      keyUp(container.querySelector('input'), KeyCode.ENTER);
       expect(onSelect).toHaveBeenCalledWith('1', expect.anything());
     }
   });

tests/utils/common.ts

@@ -106,3 +106,11 @@ export function keyDown(element: HTMLElement, keyCode: number) {
     fireEvent(element, event);
   });
 }
+
+export function keyUp(element: HTMLElement, keyCode: number) {
+  const event = createEvent.keyUp(element, { keyCode });
+
+  act(() => {
+    fireEvent(element, event);
+  });
+}