fix: display logic

Author: zombieJ

src/BaseSelect/index.tsx

@@ -395,11 +395,11 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
   );
 
   // ============================== Open ==============================
-  // Not trigger `open` in `combobox` when `notFoundContent` is empty
+  // Not trigger `open` when `notFoundContent` is empty
   const emptyListContent = !notFoundContent && emptyOptions;
 
   const [mergedOpen, triggerOpen] = useOpen(open, onPopupVisibleChange, (nextOpen) =>
-    disabled || (emptyListContent && mergedOpen && mode === 'combobox') ? false : nextOpen,
+    disabled || emptyListContent ? false : nextOpen,
   );
 
   // // SSR not support Portal which means we need delay `open` for the first time render

src/SelectInput/Content/SingleContent.tsx

@@ -22,14 +22,17 @@ export default React.forwardRef<HTMLInputElement, SharedContentProps>(function S
   const displayValue = displayValues[0];
 
   // Implement the same logic as the old SingleSelector
-  let mergedSearchValue: string = searchValue || '';
-  if (combobox && activeValue && !inputChanged && triggerOpen) {
-    mergedSearchValue = activeValue;
-  }
+  const mergedSearchValue = React.useMemo(() => {
+    if (combobox && activeValue && !inputChanged && triggerOpen) {
+      return activeValue;
+    }
+
+    return searchValue || '';
+  }, [combobox, activeValue, inputChanged, triggerOpen, searchValue]);
 
   // Extract option props, excluding label and value, and handle className/style merging
   const optionProps = React.useMemo(() => {
-    let restProps = {
+    let restProps: React.HTMLAttributes<HTMLDivElement> = {
       className: `${prefixCls}-content-value`,
       style: {
         visibility: mergedSearchValue ? 'hidden' : 'visible',

src/utils/keyUtil.ts

@@ -22,6 +22,11 @@ export function isValidateOpenKey(currentKeyCode: number): boolean {
       KeyCode.EQUALS,
       KeyCode.CAPS_LOCK,
       KeyCode.CONTEXT_MENU,
+      // Arrow keys - should not trigger open when navigating in input
+      KeyCode.UP,
+      KeyCode.DOWN,
+      KeyCode.LEFT,
+      KeyCode.RIGHT,
       // F1-F12
       KeyCode.F1,
       KeyCode.F2,

tests/shared/inputFilterTest.tsx

@@ -1,10 +1,12 @@
 import * as React from 'react';
 import Option from '../../src/Option';
 import Select from '../../src/Select';
-import { fireEvent, render } from '@testing-library/react';
+import { act, fireEvent, render } from '@testing-library/react';
 
 export default function inputFilterTest(mode: any) {
   it('should keep input filter after select when autoClearSearchValue is false', () => {
+    jest.useFakeTimers();
+
     const { container } = render(
       <Select mode={mode} autoClearSearchValue={false} showSearch>
         <Option value="11">11</Option>
@@ -22,7 +24,11 @@ export default function inputFilterTest(mode: any) {
     expect(container.querySelector('.rc-select')).toHaveClass('rc-select-open');
     expect(container.querySelector('input')).toHaveValue('1');
     fireEvent.click(container.querySelector('.rc-select-item-option'));
+    act(() => {
+      jest.runAllTimers();
+    });
     expect(container.querySelector('input')).toHaveValue(mode === 'single' ? '' : '1');
+    jest.useRealTimers();
   });
 
   it('should clear input filter after select', () => {