Skip to content

Commit cb32a2f

Browse files
committed
fix: Select selected item title
close ant-design/ant-design#25537 close ant-design/ant-design#25464
1 parent b50d608 commit cb32a2f

File tree

2 files changed

+12
-10
lines changed

2 files changed

+12
-10
lines changed

src/Selector/SingleSelector.tsx

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ const SingleSelector: React.FC<SelectorProps> = props => {
6464

6565
return (
6666
<>
67-
<span className={`${prefixCls}-selection-search`} title={title}>
67+
<span className={`${prefixCls}-selection-search`}>
6868
<Input
6969
ref={inputRef}
7070
prefixCls={prefixCls}
@@ -93,7 +93,9 @@ const SingleSelector: React.FC<SelectorProps> = props => {
9393

9494
{/* Display value */}
9595
{!combobox && item && !hasTextInput && (
96-
<span className={`${prefixCls}-selection-item`}>{item.label}</span>
96+
<span className={`${prefixCls}-selection-item`} title={title}>
97+
{item.label}
98+
</span>
9799
)}
98100

99101
{/* Display placeholder */}

tests/__snapshots__/Select.test.tsx.snap

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,6 @@ exports[`Select.Basic no search 1`] = `
186186
>
187187
<span
188188
class="rc-select-selection-search"
189-
title="1"
190189
>
191190
<input
192191
aria-activedescendant="undefined_list_0"
@@ -205,6 +204,7 @@ exports[`Select.Basic no search 1`] = `
205204
</span>
206205
<span
207206
class="rc-select-selection-item"
207+
title="1"
208208
>
209209
1
210210
</span>
@@ -233,7 +233,6 @@ exports[`Select.Basic render renders aria-attributes correctly 1`] = `
233233
>
234234
<span
235235
class="antd-selection-search"
236-
title="2"
237236
>
238237
<input
239238
aria-activedescendant="undefined_list_0"
@@ -254,6 +253,7 @@ exports[`Select.Basic render renders aria-attributes correctly 1`] = `
254253
</span>
255254
<span
256255
class="antd-selection-item"
256+
title="2"
257257
>
258258
2
259259
</span>
@@ -292,7 +292,6 @@ exports[`Select.Basic render renders correctly 1`] = `
292292
>
293293
<span
294294
class="antd-selection-search"
295-
title="2"
296295
>
297296
<input
298297
aria-activedescendant="undefined_list_0"
@@ -311,6 +310,7 @@ exports[`Select.Basic render renders correctly 1`] = `
311310
</span>
312311
<span
313312
class="antd-selection-item"
313+
title="2"
314314
>
315315
2
316316
</span>
@@ -351,7 +351,6 @@ exports[`Select.Basic render renders data-attributes correctly 1`] = `
351351
>
352352
<span
353353
class="antd-selection-search"
354-
title="2"
355354
>
356355
<input
357356
aria-activedescendant="undefined_list_0"
@@ -370,6 +369,7 @@ exports[`Select.Basic render renders data-attributes correctly 1`] = `
370369
</span>
371370
<span
372371
class="antd-selection-item"
372+
title="2"
373373
>
374374
2
375375
</span>
@@ -408,7 +408,6 @@ exports[`Select.Basic render renders disabled select correctly 1`] = `
408408
>
409409
<span
410410
class="antd-selection-search"
411-
title="2"
412411
>
413412
<input
414413
aria-activedescendant="undefined_list_0"
@@ -429,6 +428,7 @@ exports[`Select.Basic render renders disabled select correctly 1`] = `
429428
</span>
430429
<span
431430
class="antd-selection-item"
431+
title="2"
432432
>
433433
2
434434
</span>
@@ -455,7 +455,6 @@ exports[`Select.Basic render renders dropdown correctly 1`] = `
455455
>
456456
<span
457457
class="antd-selection-search"
458-
title="2"
459458
>
460459
<input
461460
aria-activedescendant="undefined_list_0"
@@ -472,6 +471,7 @@ exports[`Select.Basic render renders dropdown correctly 1`] = `
472471
</span>
473472
<span
474473
class="antd-selection-item"
474+
title="2"
475475
>
476476
2
477477
</span>
@@ -632,7 +632,6 @@ exports[`Select.Basic render renders role prop correctly 1`] = `
632632
>
633633
<span
634634
class="antd-selection-search"
635-
title="2"
636635
>
637636
<input
638637
aria-activedescendant="undefined_list_0"
@@ -651,6 +650,7 @@ exports[`Select.Basic render renders role prop correctly 1`] = `
651650
</span>
652651
<span
653652
class="antd-selection-item"
653+
title="2"
654654
>
655655
2
656656
</span>
@@ -689,7 +689,6 @@ exports[`Select.Basic should contain falsy children 1`] = `
689689
>
690690
<span
691691
class="rc-select-selection-search"
692-
title="1"
693692
>
694693
<input
695694
aria-activedescendant="undefined_list_0"
@@ -709,6 +708,7 @@ exports[`Select.Basic should contain falsy children 1`] = `
709708
</span>
710709
<span
711710
class="rc-select-selection-item"
711+
title="1"
712712
>
713713
1
714714
</span>

0 commit comments

Comments
 (0)