Skip to content

Commit d75876a

Browse files
committed
revert: rollback clearIcon
1 parent ce980b8 commit d75876a

File tree

2 files changed

+14
-3
lines changed

2 files changed

+14
-3
lines changed

src/BaseSelect/index.tsx

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,11 @@ export interface BaseSelectProps extends BaseSelectPrivateProps, React.AriaAttri
175175
allowClear?: boolean | { clearIcon?: RenderNode };
176176
prefix?: React.ReactNode;
177177
suffixIcon?: RenderNode;
178+
/**
179+
* Clear all icon
180+
* @deprecated Please use `allowClear` instead
181+
**/
182+
clearIcon?: RenderNode;
178183
/** Selector remove icon */
179184
removeIcon?: RenderNode;
180185

@@ -257,6 +262,7 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
257262
allowClear,
258263
prefix,
259264
suffixIcon,
265+
clearIcon,
260266

261267
// Dropdown
262268
OptionList,
@@ -727,6 +733,7 @@ const BaseSelect = React.forwardRef<BaseSelectRef, BaseSelectProps>((props, ref)
727733
onClearMouseDown,
728734
displayValues,
729735
allowClear,
736+
clearIcon,
730737
disabled,
731738
mergedSearchValue,
732739
mode,

src/hooks/useAllowClear.tsx

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,15 +7,19 @@ export const useAllowClear = (
77
onClearMouseDown: React.MouseEventHandler<HTMLSpanElement>,
88
displayValues: DisplayValueType[],
99
allowClear?: boolean | { clearIcon?: RenderNode },
10+
clearIcon?: RenderNode,
1011
disabled: boolean = false,
1112
mergedSearchValue?: string,
1213
mode?: Mode,
1314
) => {
14-
const clearIcon = React.useMemo(() => {
15+
const mergedClearIcon = React.useMemo(() => {
1516
if (typeof allowClear === 'object') {
1617
return allowClear.clearIcon;
1718
}
18-
}, [allowClear]);
19+
if (clearIcon) {
20+
return clearIcon;
21+
}
22+
}, [allowClear, clearIcon]);
1923

2024
const mergedAllowClear = React.useMemo<boolean>(() => {
2125
if (
@@ -35,7 +39,7 @@ export const useAllowClear = (
3539
<TransBtn
3640
className={`${prefixCls}-clear`}
3741
onMouseDown={onClearMouseDown}
38-
customizeIcon={clearIcon}
42+
customizeIcon={mergedClearIcon}
3943
>
4044
×
4145
</TransBtn>

0 commit comments

Comments
 (0)