Skip to content

Commit ed5a3d7

Browse files
authored
fix: select TagRender prop does not close dropdown when clicked when dropdown is open (#617)
* fix: select TagRender prop does not close dropdown when clicked when dropdown is open * test: expect a second click on a custom tag to close the dropdown Co-authored-by: Matan Shavit <[email protected]>
1 parent e7a7428 commit ed5a3d7

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

src/Selector/MultipleSelector.tsx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -127,7 +127,7 @@ const SelectSelector: React.FC<SelectorProps> = (props) => {
127127
) {
128128
const onMouseDown = (e: React.MouseEvent) => {
129129
onPreventMouseDown(e);
130-
onToggleOpen(true);
130+
onToggleOpen(!open);
131131
};
132132

133133
return (

tests/Tags.test.tsx

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -295,6 +295,9 @@ describe('Select.Tags', () => {
295295
expect(wrapper.find('span.A').text()).toBe('AA');
296296
expect(onTagRender).toHaveBeenCalled();
297297
expect(wrapper.find('.customize-tag')).toHaveLength(3);
298+
299+
wrapper.find('span.A').simulate('mousedown');
300+
expectOpen(wrapper, false);
298301
});
299302

300303
it('disabled', () => {

0 commit comments

Comments
 (0)