refactor: use rc-util useId #1155

zombieJ · 2025-06-03T09:08:50Z

Summary by CodeRabbit

重构
- 优化了唯一 ID 生成逻辑，移除本地实现，改为使用外部依赖库的方案。

vercel · 2025-06-03T09:08:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
select	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jun 3, 2025 9:09am

coderabbitai · 2025-06-03T09:08:56Z

Walkthrough

本次更改将 useId 钩子的导入路径从本地实现切换为外部包 @rc-component/util，并删除了项目中自定义的 useId 实现。其余代码和逻辑未发生变化。

Changes

文件/路径	变更摘要
src/Select.tsx	`useId` 钩子的导入路径改为外部包
src/hooks/useId.ts	删除自定义的 `useId` 实现及相关导出

Poem

🐇
跳跳小兔换新装，
钩子外包更轻松。
旧文件说再见，
新路径来护航。
代码世界常更新，
快乐开发每一行！

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

src/Select.tsx

Oops! Something went wrong! :(

ESLint: 8.57.1

Error: Cannot read config file: /.eslintrc.js
Error: Cannot find module '@umijs/fabric/dist/eslint'
Require stack:

/.eslintrc.js
/node_modules/.pnpm/@eslint [email protected]/node_modules/@eslint/eslintrc/dist/eslintrc.cjs
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli-engine/cli-engine.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/eslint.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/eslint/index.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/lib/cli.js
/node_modules/.pnpm/[email protected]/node_modules/eslint/bin/eslint.js
at Module._resolveFilename (node:internal/modules/cjs/loader:1405:15)
at defaultResolveImpl (node:internal/modules/cjs/loader:1061:19)
at resolveForCJSWithHooks (node:internal/modules/cjs/loader:1066:22)
at Module._load (node:internal/modules/cjs/loader:1215:37)
at TracingChannel.traceSync (node:diagnostics_channel:322:14)
at wrapModuleLoad (node:internal/modules/cjs/loader:235:24)
at Module.require (node:internal/modules/cjs/loader:1491:12)
at require (node:internal/modules/helpers:135:16)
at Object. (/.eslintrc.js:1:14)
at Module._compile (node:internal/modules/cjs/loader:1734:14)

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between b0b7473 and 46d39d3.

⛔ Files ignored due to path filters (5)

tests/__snapshots__/Combobox.test.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/Multiple.test.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/Select.test.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/Tags.test.tsx.snap is excluded by !**/*.snap
tests/__snapshots__/ssr.test.tsx.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

src/Select.tsx (1 hunks)
src/hooks/useId.ts (0 hunks)

💤 Files with no reviewable changes (1)

src/hooks/useId.ts

🔇 Additional comments (1)

src/Select.tsx (1)

52-52:
✅ Verification successful

切换 useId 导入来源
此处已将本地实现替换为 @rc-component/util/lib/hooks/useId，与项目中其它钩子保持一致。请确认已在 package.json 中正确添加或升级 @rc-component/util 依赖，并确保所使用的版本中该路径可用。

可以运行以下脚本来验证依赖与残留引用：

🏁 Script executed:
#!/usr/bin/env bash
# 验证 package.json 中是否包含 @rc-component/util
grep -R "\"@rc-component/util\"" package.json || echo "❌ 缺少 @rc-component/util 依赖"
# 确认本地 hooks/useId.ts 文件是否已删除且无残留导入
rg "from ['\"]\./hooks/useId['\"]" -l src || echo "✅ 本地 useId 导入已清理"
Length of output: 172
✅ 已确认 useId 依赖及引用均已更新

package.json 中已声明 "@rc-component/util": "^1.2.1"

本地 ./hooks/useId 导入已删除，无残留引用

无需进一步操作。

✨ Finishing Touches

📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-06-03T09:09:59Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (b0b7473) to head (46d39d3).
Report is 2 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #1155      +/-   ##
==========================================
- Coverage   98.27%   98.26%   -0.02%     
==========================================
  Files          39       38       -1     
  Lines        1508     1496      -12     
  Branches      456      452       -4     
==========================================
- Hits         1482     1470      -12     
  Misses         26       26

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

refactor: use rc-util useId

46d39d3

vercel bot deployed to Preview June 3, 2025 09:09 View deployment

Wxh16144 approved these changes Jun 3, 2025

View reviewed changes

zombieJ merged commit 206aeb0 into master Jun 3, 2025
11 of 12 checks passed

zombieJ deleted the useId branch June 3, 2025 09:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

refactor: use rc-util useId #1155

refactor: use rc-util useId #1155

Uh oh!

zombieJ commented Jun 3, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Jun 3, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Jun 3, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

refactor: use rc-util useId #1155

refactor: use rc-util useId #1155

Uh oh!

Conversation

zombieJ commented Jun 3, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

vercel bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

zombieJ commented Jun 3, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Jun 3, 2025 •

edited

Loading

coderabbitai bot commented Jun 3, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jun 3, 2025 •

edited

Loading