fix: improve useDelayReset logic and add focus test for Select #1160

QdabuliuQ · 2025-08-01T13:49:25Z

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

Select component doesn't show focus style when calling focus() after enabling StrictMode
In StrictMode, useEffect executes multiple times. The delaySetBool method distinguishes the value - if it's false, it enters the delay branch.

📝 Change Log

Language	Changelog
🇺🇸 English	Fix Select component style error after calling focus in StrictMode
🇨🇳 Chinese	修复 StrictMode 下调用 focus 后 Select 样式错误

Summary by CodeRabbit

修复问题
- 修正了布尔状态延迟设置的逻辑，现在设置为 true 时会立即生效并可选回调，设置为 false 时则延迟处理。
测试
- 新增了 Select 组件在受控聚焦状态下的样式测试，确保输入框聚焦时样式正确应用。

vercel · 2025-08-01T13:49:29Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
select	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 1, 2025 3:22pm

coderabbitai · 2025-08-01T13:49:32Z

Walkthrough

本次变更主要涉及 useDelayReset 钩子的实现优化和 Select 组件的测试增强。useDelayReset 钩子的延迟逻辑被调整为仅在设置为 false 时延迟，且回调参数变为可选。同时，测试文件新增了在 StrictMode 下聚焦 Select 组件的相关用例。

Changes

Cohort / File(s)	Change Summary
useDelayReset 钩子实现调整 `src/hooks/useDelayReset.ts`	优化延迟逻辑：设置为 `true` 时立即生效，设置为 `false` 时延迟。回调参数变为可选，`useEffect` 清理函数形式调整。
Select 组件测试增强 `tests/Select.test.tsx`	新增在 `StrictMode` 下动态添加并聚焦 `Select` 的测试用例，验证聚焦样式是否正确应用。

Sequence Diagram(s)

sequenceDiagram
    participant ReactComponent as 组件
    participant useDelayReset
    participant setState
    participant callback

    ReactComponent->>useDelayReset: 调用 delaySetBool(true, cb)
    useDelayReset->>setState: 立即设置为 true
    alt 有回调
        useDelayReset->>callback: 立即执行
    end

    ReactComponent->>useDelayReset: 调用 delaySetBool(false, cb)
    useDelayReset->>setTimeout: 延迟后设置为 false
    alt 有回调
        useDelayReset->>callback: 延迟后执行
    end

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Assessment against linked issues

Objective	Addressed	Explanation
修复 StrictMode 下动态添加 Select 后调用 focus 不生效 (#54546)	✅
Select 组件聚焦时应有 focus 效果 (#54546)	✅

Assessment against linked issues: Out-of-scope changes

无发现超出关联 issue 目标的代码变更。

Poem

兔子跳跃乐无边，
钩子优化快如烟。
Select 聚焦新测试，
严格模式不再难。
代码清晰又明了，
审阅轻松心喜欢！
🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a34b041 and 11f3768.

📒 Files selected for processing (1)

src/hooks/useDelayReset.ts (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

src/hooks/useDelayReset.ts

✨ Finishing Touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai generate unit tests to generate unit tests for this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-08-01T15:19:29Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.11%. Comparing base (48e2457) to head (11f3768).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1160   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          39       39           
  Lines        1484     1489    +5     
  Branches      422      444   +22     
=======================================
+ Hits         1456     1461    +5     
  Misses         28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

src/hooks/useDelayReset.ts

fix: improve useDelayReset logic and add focus test for Select

a34b041

QdabuliuQ mentioned this pull request Aug 1, 2025

StrictMode下动态添加Select后调用focus不生效 ant-design/ant-design#54546

Closed

vercel bot deployed to Preview August 1, 2025 13:50 View deployment

afc163 approved these changes Aug 1, 2025

View reviewed changes

afc163 reviewed Aug 1, 2025

View reviewed changes

src/hooks/useDelayReset.ts Outdated Show resolved Hide resolved

Update src/hooks/useDelayReset.ts

d6687be

vercel bot deployed to Preview August 1, 2025 15:21 View deployment

Update useDelayReset.ts

11f3768

vercel bot deployed to Preview August 1, 2025 15:22 View deployment

afc163 merged commit 6fda954 into react-component:master Aug 1, 2025
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

fix: improve useDelayReset logic and add focus test for Select #1160

fix: improve useDelayReset logic and add focus test for Select #1160

Uh oh!

QdabuliuQ commented Aug 1, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Aug 1, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Aug 1, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Aug 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

fix: improve useDelayReset logic and add focus test for Select #1160

fix: improve useDelayReset logic and add focus test for Select #1160

Uh oh!

Conversation

QdabuliuQ commented Aug 1, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 This is a ...

🔗 Related Issues

💡 Background and Solution

📝 Change Log

Summary by CodeRabbit

Uh oh!

vercel bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Sequence Diagram(s)

Estimated code review effort

Assessment against linked issues

Assessment against linked issues: Out-of-scope changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Aug 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

QdabuliuQ commented Aug 1, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Aug 1, 2025 •

edited

Loading

coderabbitai bot commented Aug 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Aug 1, 2025 •

edited

Loading