perf: uninstall classnames, install clsx #1164

li-jia-nan · 2025-09-28T05:13:23Z

No description provided.

vercel · 2025-09-28T05:13:28Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Preview	Comments	Updated (UTC)
select	Ready	Preview	Comment	Sep 28, 2025 5:18am

coderabbitai · 2025-09-28T05:13:30Z

Warning

Rate limit exceeded

@li-jia-nan has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 18 minutes and 43 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between eac8428 and 09a6e57.

📒 Files selected for processing (10)

.gitignore (1 hunks)
package.json (2 hunks)
src/BaseSelect/index.tsx (3 hunks)
src/OptionList.tsx (3 hunks)
src/SelectTrigger.tsx (2 hunks)
src/Selector/Input.tsx (2 hunks)
src/Selector/MultipleSelector.tsx (2 hunks)
src/Selector/index.tsx (2 hunks)
src/TransBtn.tsx (2 hunks)
tests/Tags.test.tsx (2 hunks)

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

✨ Finishing touches

📝 Generate Docstrings

🧪 Generate unit tests

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch clsx-update

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codecov · 2025-09-28T05:13:41Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.11%. Comparing base (eac8428) to head (09a6e57).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1164   +/-   ##
=======================================
  Coverage   98.11%   98.11%           
=======================================
  Files          39       39           
  Lines        1489     1489           
  Branches      452      445    -7     
=======================================
  Hits         1461     1461           
  Misses         28       28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

gemini-code-assist · 2025-09-28T05:13:42Z

Summary of Changes

Hello @li-jia-nan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request primarily focuses on a performance optimization by migrating from the classnames utility library to clsx for constructing CSS class strings. This change is reflected in the project's dependencies and across several UI components where dynamic class names are generated, ensuring a more optimized and potentially faster rendering experience. Minor updates to development tooling and ignored files are also included.

Highlights

Dependency Swap: The classnames utility library has been uninstalled and replaced with clsx in the project's dependencies, aiming for performance improvements.
Code Refactoring: All instances of classnames usage across various component files (e.g., OptionList.tsx, SelectTrigger.tsx, Selector/index.tsx) and a test file (Tags.test.tsx) have been updated to use clsx.
Build Configuration Updates: The .gitignore file has been updated to include pnpm-lock.yaml, and @types/node has been added to devDependencies in package.json.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

socket-security · 2025-09-28T05:13:56Z

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff	Package	Supply Chain Security	Vulnerability	Quality	Maintenance	License
	clsx@2.1.1

View full report

gemini-code-assist

Code Review

This pull request aims to improve performance by replacing classnames with clsx. While the changes made are a good step, the refactoring is incomplete. The classnames dependency is removed from package.json, but it is still imported and used in src/Selector/Input.tsx and src/BaseSelect/index.tsx. This will cause the build to fail and is a critical issue that needs to be addressed before merging. I have added a comment on package.json to highlight this.

package.json

perf: uninstall classnames, install clsx

29ef53f

li-jia-nan mentioned this pull request Sep 28, 2025

perf: uninstall classnames, install clsx ant-design/ant-design#55164

Merged

gemini-code-assist bot reviewed Sep 28, 2025

View reviewed changes

package.json Show resolved Hide resolved

perf: uninstall classnames, install clsx

09a6e57

vercel bot deployed to Preview September 28, 2025 05:18 View deployment

li-jia-nan merged commit c2dc268 into master Sep 28, 2025
12 checks passed

li-jia-nan deleted the clsx-update branch September 28, 2025 06:42

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

perf: uninstall classnames, install clsx #1164

perf: uninstall classnames, install clsx #1164

Uh oh!

li-jia-nan commented Sep 28, 2025

Uh oh!

vercel bot commented Sep 28, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Sep 28, 2025 •

edited

Loading

Rate limit exceeded

Other AI code review bot(s) detected

Uh oh!

codecov bot commented Sep 28, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot commented Sep 28, 2025

Uh oh!

socket-security bot commented Sep 28, 2025 •

edited

Loading

Uh oh!

gemini-code-assist bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

perf: uninstall classnames, install clsx #1164

perf: uninstall classnames, install clsx #1164

Uh oh!

Conversation

li-jia-nan commented Sep 28, 2025

Uh oh!

vercel bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Rate limit exceeded

Other AI code review bot(s) detected

Uh oh!

codecov bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

gemini-code-assist bot commented Sep 28, 2025

Summary of Changes

Highlights

Footnotes

Uh oh!

socket-security bot commented Sep 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gemini-code-assist bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vercel bot commented Sep 28, 2025 •

edited

Loading

coderabbitai bot commented Sep 28, 2025 •

edited

Loading

codecov bot commented Sep 28, 2025 •

edited

Loading

socket-security bot commented Sep 28, 2025 •

edited

Loading