chore: Not render 0 width col (#446)

* keep last col

* fix test case

Author: zombieJ

src/ColGroup.tsx

@@ -12,11 +12,18 @@ function ColGroup<RecordType>({ colWidths, columns, columCount }: ColGroupProps<
   const cols: React.ReactElement[] = [];
   const len = columCount || columns.length;
 
-  for (let i = 0; i < len; i += 1) {
+  // Only insert col with width & additional props
+  // Skip if rest col do not have any useful info
+  let mustInsert = false;
+  for (let i = len - 1; i >= 0; i -= 1) {
     const width = colWidths[i];
     const column = columns && columns[i];
     const additionalProps = column && column[INTERNAL_COL_DEFINE];
-    cols.push(<col key={i} style={{ width, minWidth: width }} {...additionalProps} />);
+
+    if (width || additionalProps || mustInsert) {
+      cols.unshift(<col key={i} style={{ width, minWidth: width }} {...additionalProps} />);
+      mustInsert = true;
+    }
   }
 
   return <colgroup>{cols}</colgroup>;

tests/Colgroup.spec.js

@@ -19,6 +19,7 @@ describe('Table.ColGroup', () => {
     const columns = [
       {
         key: 0,
+        width: 1,
       },
     ];
 

tests/__snapshots__/ExpandRow.spec.js.snap

@@ -13,10 +13,7 @@ exports[`Table.Expand childrenColumnName 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="rc-table-thead"
         >
@@ -124,9 +121,6 @@ exports[`Table.Expand renders fixed column correctly work 1`] = `
           <col
             class="rc-table-expand-icon-col"
           />
-          <col />
-          <col />
-          <col />
         </colgroup>
         <thead
           class="rc-table-thead"
@@ -290,10 +284,7 @@ exports[`Table.Expand renders tree row correctly 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="rc-table-thead"
         >
@@ -396,10 +387,7 @@ exports[`Table.Expand renders tree row correctly with different children 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="rc-table-thead"
         >

tests/__snapshots__/Table.spec.js.snap

@@ -14,9 +14,7 @@ exports[`Table.Basic custom components renders correctly 1`] = `
         name="my-table"
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="rc-table-thead"
           name="my-header-wrapper"
@@ -133,11 +131,7 @@ exports[`Table.Basic custom components renders fixed column and header correctly
         name="my-table"
         style="width: 100px; min-width: 100%; table-layout: fixed;"
       >
-        <colgroup>
-          <col />
-          <col />
-          <col />
-        </colgroup>
+        <colgroup />
         <tbody
           class="rc-table-tbody"
           name="my-body-wrapper"
@@ -252,11 +246,7 @@ exports[`Table.Basic internal api transformColumns 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-          <col />
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="rc-table-thead"
         >
@@ -333,10 +323,7 @@ exports[`Table.Basic renders colSpan correctly 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="rc-table-thead"
         >
@@ -398,9 +385,7 @@ exports[`Table.Basic renders correctly RTL 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="test-prefix-thead"
         >
@@ -455,9 +440,7 @@ exports[`Table.Basic renders correctly basic 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="test-prefix-thead"
         >
@@ -512,9 +495,7 @@ exports[`Table.Basic renders correctly no columns 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="rc-table-thead"
         >
@@ -563,10 +544,7 @@ exports[`Table.Basic renders rowSpan correctly 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="rc-table-thead"
         >
@@ -632,9 +610,7 @@ exports[`Table.Basic syntactic sugar 1`] = `
       <table
         style="table-layout: auto;"
       >
-        <colgroup>
-          <col />
-        </colgroup>
+        <colgroup />
         <thead
           class="rc-table-thead"
         >